]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
usb: dwc3: trace: add missing break statement to make compiler happy
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Dec 2018 09:28:47 +0000 (11:28 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
BugLink: https://bugs.launchpad.net/bugs/1837664
[ Upstream commit 54d48183d21e03f780053d7129312049cb5dd591 ]

The missed break statement in the outer switch makes the code fall through
always and thus always same value will be printed.

Besides that, compiler warns about missed fall through marker:

drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’:
drivers/usb/dwc3/./trace.h:246:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (pcm) {
    ^~~~~~

Add the missing break statement to work correctly without compilation
warnings.

Fixes: fa8d965d736b ("usb: dwc3: trace: pretty print high-bandwidth transfers too")
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/usb/dwc3/trace.h

index a9dd5c64e6c71b90a9c6634ef61bcabc82b60126..ed62d3e93536082e594f9ef41b0c20da19bfab8f 100644 (file)
@@ -254,9 +254,11 @@ DECLARE_EVENT_CLASS(dwc3_log_trb,
                                s = "2x ";
                                break;
                        case 3:
+                       default:
                                s = "3x ";
                                break;
                        }
+                       break;
                default:
                        s = "";
                } s; }),