]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
audit: use audit_set_enabled() in audit_enable()
authorPaul Moore <paul@paul-moore.com>
Fri, 1 Sep 2017 13:45:05 +0000 (09:45 -0400)
committerPaul Moore <paul@paul-moore.com>
Fri, 10 Nov 2017 21:07:57 +0000 (16:07 -0500)
Use audit_set_enabled() to enable auditing during early boot.  This
obviously won't emit an audit change record, but it will work anyway
and should help prevent in future problems by consolidating the
enable/disable code in one function.

Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
kernel/audit.c

index f0cf9bfc806cc832f65074ba0970083228521cd2..67b3863261d4494b2e71ed0ed4bcde0bbe2bcf7a 100644 (file)
@@ -1575,8 +1575,8 @@ static int __init audit_enable(char *str)
 
        if (audit_default == AUDIT_OFF)
                audit_initialized = AUDIT_DISABLED;
-       audit_enabled = audit_default;
-       audit_ever_enabled = !!audit_enabled;
+       if (audit_set_enabled(audit_default))
+               panic("audit: error setting audit state (%d)\n", audit_default);
 
        pr_info("%s\n", audit_default ?
                "enabled (after initialization)" : "disabled (until reboot)");