perf: arm_spe: Fail device probe when arm64_kernel_unmapped_at_el0()

BugLink: http://bugs.launchpad.net/bugs/1751064
Commit 7a4a0c1555b8 upstream.

When running with the kernel unmapped whilst at EL0, the virtually-addressed
SPE buffer is also unmapped, which can lead to buffer faults if userspace
profiling is enabled and potentially also when writing back kernel samples
unless an expensive drain operation is performed on exception return.

For now, fail the SPE driver probe when arm64_kernel_unmapped_at_el0().

Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Laura Abbott <labbott@redhat.com>
Tested-by: Shanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>

diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
index 8ce262fc256133a22f6e698d4cb40e94a1f2b91d..51b40aecb7768825c7422f02a7bf6a07d4351601 100644 (file)
--- a/drivers/perf/arm_spe_pmu.c
+++ b/drivers/perf/arm_spe_pmu.c
@@ -1164,6 +1164,15 @@ static int arm_spe_pmu_device_dt_probe(struct platform_device *pdev)
        struct arm_spe_pmu *spe_pmu;
        struct device *dev = &pdev->dev;
 
+       /*
+        * If kernelspace is unmapped when running at EL0, then the SPE
+        * buffer will fault and prematurely terminate the AUX session.
+        */
+       if (arm64_kernel_unmapped_at_el0()) {
+               dev_warn_once(dev, "profiling buffer inaccessible. Try passing \"kpti=off\" on the kernel command line\n");
+               return -EPERM;
+       }
+
        spe_pmu = devm_kzalloc(dev, sizeof(*spe_pmu), GFP_KERNEL);
        if (!spe_pmu) {
                dev_err(dev, "failed to allocate spe_pmu\n");