]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ima: remove unnecessary appraisal test
authorDmitry Kasatkin <d.kasatkin@samsung.com>
Wed, 20 Aug 2014 09:37:57 +0000 (12:37 +0300)
committerMimi Zohar <zohar@linux.vnet.ibm.com>
Tue, 9 Sep 2014 14:28:51 +0000 (10:28 -0400)
ima_get_action() sets the "action" flags based on policy.
Before collecting, measuring, appraising, or auditing the
file, the "action" flag is updated based on the cached
iint->flags.

This patch removes the subsequent unnecessary appraisal
test in ima_appraise_measurement().

Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
security/integrity/ima/ima_appraise.c

index 225fd944a4efbcad30a489af66f0eb47ba877823..013ec3f0e42da5e7809bbe87edfad69a56347b4e 100644 (file)
@@ -192,8 +192,6 @@ int ima_appraise_measurement(int func, struct integrity_iint_cache *iint,
        enum integrity_status status = INTEGRITY_UNKNOWN;
        int rc = xattr_len, hash_start = 0;
 
-       if (!ima_appraise)
-               return 0;
        if (!inode->i_op->getxattr)
                return INTEGRITY_UNKNOWN;