]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
selftests: intel_pstate: return Kselftest Skip code for skipped tests
authorShuah Khan (Samsung OSG) <shuah@kernel.org>
Thu, 3 May 2018 23:09:40 +0000 (17:09 -0600)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 1 Mar 2019 13:20:34 +0000 (14:20 +0100)
BugLink: http://bugs.launchpad.net/bugs/1815234
[ Upstream commit 5c30a038fb8ec8cdff011e6b5d5d51eb415381d4 ]

When intel_pstate test is skipped because of unmet dependencies and/or
unsupported configuration, it returns 0 which is treated as a pass
by the Kselftest framework. This leads to false positive result even
when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/testing/selftests/intel_pstate/run.sh

index bde31a0be5ca6b1214e4071ebf7a87a9110c1ab3..92897880434241fe08c36580997b42a18a4f2546 100755 (executable)
 
 EVALUATE_ONLY=0
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
 if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
        echo "$0 # Skipped: Test can only run on x86 architectures."
-       exit 0
+       exit $ksft_skip
 fi
 
 max_cpus=$(($(nproc)-1))