]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
xen/gntdev: Fix off-by-one error when unmapping with holes
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Tue, 9 Jan 2018 12:10:21 +0000 (12:10 +0000)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Wed, 10 Jan 2018 13:38:17 +0000 (08:38 -0500)
If the requested range has a hole, the calculation of the number of
pages to unmap is off by one. Fix it.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/gntdev.c

index 57efbd3b053b37ca43816483dd3364c3c48a761e..d3391a1e3796beadd761b2900f325f617637e46d 100644 (file)
@@ -380,10 +380,8 @@ static int unmap_grant_pages(struct grant_map *map, int offset, int pages)
                }
                range = 0;
                while (range < pages) {
-                       if (map->unmap_ops[offset+range].handle == -1) {
-                               range--;
+                       if (map->unmap_ops[offset+range].handle == -1)
                                break;
-                       }
                        range++;
                }
                err = __unmap_grant_pages(map, offset, range);