]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
media: au0828: fix unbalanced lock/unlock in au0828_usb_probe
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sat, 12 Aug 2017 17:30:59 +0000 (13:30 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 10:57:33 +0000 (06:57 -0400)
Call mutex_unlock and free dev on failure.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/au0828/au0828-core.c

index 739df61cec4f7049a838d27d6c80b4d7ec682040..cd363a2100d453c6b5be15b35430907acd44cdde 100644 (file)
@@ -628,6 +628,8 @@ static int au0828_usb_probe(struct usb_interface *interface,
        if (retval) {
                pr_err("%s() au0282_dev_register failed to register on V4L2\n",
                        __func__);
+               mutex_unlock(&dev->lock);
+               kfree(dev);
                goto done;
        }