]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
regulator: ab8500: Remove SYSCLKREQ from enum ab8505_regulator_id
authorStephan Gerhold <stephan@gerhold.net>
Wed, 6 Nov 2019 17:31:25 +0000 (18:31 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1862259
commit 458ea3ad033fc86e291712ce50cbe60c3428cf30 upstream.

Those regulators are not actually supported by the AB8500 regulator
driver. There is no ab8500_regulator_info for them and no entry in
ab8505_regulator_match.

As such, they cannot be registered successfully, and looking them
up in ab8505_regulator_match causes an out-of-bounds array read.

Fixes: 547f384f33db ("regulator: ab8500: add support for ab8505")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20191106173125.14496-2-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
include/linux/regulator/ab8500.h

index 260c4aa1d9761aed1e52f92537ce984ecd1d0740..3f6b8b9ef49da3258c53e0eae4660b150fe5bc25 100644 (file)
@@ -43,8 +43,6 @@ enum ab8505_regulator_id {
        AB8505_LDO_ANAMIC2,
        AB8505_LDO_AUX8,
        AB8505_LDO_ANA,
-       AB8505_SYSCLKREQ_2,
-       AB8505_SYSCLKREQ_4,
        AB8505_NUM_REGULATORS,
 };