]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
regulator: pv88090: Fix array out-of-bounds access
authorAxel Lin <axel.lin@ingics.com>
Tue, 19 Feb 2019 10:00:02 +0000 (18:00 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit a5455c9159414748bed4678184bf69989a4f7ba3 ]

Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.

Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/regulator/pv88090-regulator.c

index 7a0c15957bd0b710ec25b65454fe0474ca5f87d7..2302b0df7630f08a090679183bc87a3549645772 100644 (file)
@@ -157,7 +157,7 @@ static int pv88090_set_current_limit(struct regulator_dev *rdev, int min,
        int i;
 
        /* search for closest to maximum */
-       for (i = info->n_current_limits; i >= 0; i--) {
+       for (i = info->n_current_limits - 1; i >= 0; i--) {
                if (min <= info->current_limits[i]
                        && max >= info->current_limits[i]) {
                        return regmap_update_bits(rdev->regmap,