]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
Input: gamecon - mark expected switch fall-throughs
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 10 Nov 2017 18:23:59 +0000 (10:23 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 10 Nov 2017 18:29:55 +0000 (10:29 -0800)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114761
Addresses-Coverity-ID: 114762
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/gamecon.c

index c43f087a496d4864fe45d9b60c4386fd9763c6fa..ca734ea97e53e9fed5dca03f53a59e20607fe569 100644 (file)
@@ -654,6 +654,7 @@ static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type,
 
                input_report_key(dev, BTN_THUMBL, ~data[0] & 0x04);
                input_report_key(dev, BTN_THUMBR, ~data[0] & 0x02);
+               /* fall through */
 
        case GC_PSX_NEGCON:
        case GC_PSX_ANALOG:
@@ -887,6 +888,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)
        case GC_SNES:
                for (i = 4; i < 8; i++)
                        __set_bit(gc_snes_btn[i], input_dev->keybit);
+               /* fall through */
        case GC_NES:
                for (i = 0; i < 4; i++)
                        __set_bit(gc_snes_btn[i], input_dev->keybit);
@@ -894,6 +896,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type)
 
        case GC_MULTI2:
                __set_bit(BTN_THUMB, input_dev->keybit);
+               /* fall through */
        case GC_MULTI:
                __set_bit(BTN_TRIGGER, input_dev->keybit);
                break;