]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
jump_label: Fix anonymous union initialization
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Tue, 28 Feb 2017 16:32:22 +0000 (11:32 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 3 Mar 2017 14:44:59 +0000 (09:44 -0500)
Pre-4.6 gcc do not allow direct static initialization of members of
anonymous structs/unions. After commit 3821fd35b58d ("jump_label:
Reduce the size of struct static_key") STATIC_KEY_INIT_{TRUE|FALSE}
definitions cannot be compiled with those older compilers.

Placing initializers inside curved brackets works around this problem.

Link: http://lkml.kernel.org/r/1488299542-30765-1-git-send-email-boris.ostrovsky@oracle.com
Fixes: 3821fd35b58d ("jump_label: Reduce the size of struct static_key")
Reviewed-by: Jason Baron <jbaron@akamai.com>
Compiled-by: Chris Mason <clm@fb.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
include/linux/jump_label.h

index 680c98b2f41c06a462d5f4762f5088ab7efa16ac..a7f90117cf7d4f4d71fd1d6d2bc8a0d47e272d1a 100644 (file)
@@ -166,10 +166,10 @@ extern void static_key_disable(struct static_key *key);
  */
 #define STATIC_KEY_INIT_TRUE                                   \
        { .enabled = { 1 },                                     \
-         .entries = (void *)JUMP_TYPE_TRUE }
+         { .entries = (void *)JUMP_TYPE_TRUE } }
 #define STATIC_KEY_INIT_FALSE                                  \
        { .enabled = { 0 },                                     \
-         .entries = (void *)JUMP_TYPE_FALSE }
+         { .entries = (void *)JUMP_TYPE_FALSE } }
 
 #else  /* !HAVE_JUMP_LABEL */