]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
HID: i2c-hid: Fix error handling
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 19 Feb 2017 12:07:59 +0000 (13:07 +0100)
committerJiri Kosina <jkosina@suse.cz>
Mon, 6 Mar 2017 13:16:13 +0000 (14:16 +0100)
According to error handling in this function, it is likely that some
resources should be freed before returning.
Replace 'return ret', with 'goto err'.

While at it, remove some spaces at the beginning of the lines to be more
consistent.

Fixes: ead0687fe304a ("HID: i2c-hid: support regulator power on/off")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/i2c-hid/i2c-hid.c

index a3f6daf0886b476dfa23eebf254da12e47a5853e..a8381494946723c476946a8dbb1af485056d801b 100644 (file)
@@ -1064,7 +1064,7 @@ static int i2c_hid_probe(struct i2c_client *client,
                if (ret != -EPROBE_DEFER)
                        dev_err(&client->dev, "Failed to get regulator: %d\n",
                                ret);
-               return ret;
+               goto err;
        }
 
        ret = regulator_enable(ihid->pdata.supply);