]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ASoC: davinci-mcasp: Fix clang warning without CONFIG_PM
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 Mar 2019 10:11:30 +0000 (11:11 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
BugLink: https://bugs.launchpad.net/bugs/1838700
[ Upstream commit 8ca5104715cfd14254ea5aecc390ae583b707607 ]

Building with clang shows a variable that is only used by the
suspend/resume functions but defined outside of their #ifdef block:

sound/soc/ti/davinci-mcasp.c:48:12: error: variable 'context_regs' is not needed and will not be emitted

We commonly fix these by marking the PM functions as __maybe_unused,
but here that would grow the davinci_mcasp structure, so instead
add another #ifdef here.

Fixes: 1cc0c054f380 ("ASoC: davinci-mcasp: Convert the context save/restore to use array")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/soc/davinci/davinci-mcasp.c

index 804c6f2bcf218a61b492e1a67e24d6d3491b8229..9b0e7a09dfdbd1b3499719a52b1b411ee5ea84b4 100644 (file)
@@ -43,6 +43,7 @@
 
 #define MCASP_MAX_AFIFO_DEPTH  64
 
+#ifdef CONFIG_PM
 static u32 context_regs[] = {
        DAVINCI_MCASP_TXFMCTL_REG,
        DAVINCI_MCASP_RXFMCTL_REG,
@@ -65,6 +66,7 @@ struct davinci_mcasp_context {
        u32     *xrsr_regs; /* for serializer configuration */
        bool    pm_state;
 };
+#endif
 
 struct davinci_mcasp_ruledata {
        struct davinci_mcasp *mcasp;