]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
rtl8xxxu: Don't printk raw binary if serial number is not burned in.
authorAdam Borowski <kilobyte@angband.pl>
Fri, 8 Sep 2017 10:30:00 +0000 (12:30 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 25 Sep 2017 08:24:05 +0000 (11:24 +0300)
I assume that a blank efuse comes with all ones, thus I did not bother
recognizing other possible junk values.  This matches 100% of dongles
I've seen (a single Gembird 8192eu).

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c

index 80fee699f58a0914440689481ee13e44eb113ed2..38b2ba1ac6f8cfd5cae97b59a2120e800e622383 100644 (file)
@@ -614,7 +614,10 @@ static int rtl8192eu_parse_efuse(struct rtl8xxxu_priv *priv)
 
        dev_info(&priv->udev->dev, "Vendor: %.7s\n", efuse->vendor_name);
        dev_info(&priv->udev->dev, "Product: %.11s\n", efuse->device_name);
-       dev_info(&priv->udev->dev, "Serial: %.11s\n", efuse->serial);
+       if (memchr_inv(efuse->serial, 0xff, 11))
+               dev_info(&priv->udev->dev, "Serial: %.11s\n", efuse->serial);
+       else
+               dev_info(&priv->udev->dev, "Serial not available.\n");
 
        if (rtl8xxxu_debug & RTL8XXXU_DEBUG_EFUSE) {
                unsigned char *raw = priv->efuse_wifi.raw;