]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
usb: dwc3: don't log probe deferrals; but do log other error codes
authorBrian Norris <briannorris@chromium.org>
Wed, 7 Nov 2018 20:40:29 +0000 (12:40 -0800)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:12 +0000 (14:22 -0300)
BugLink: https://bugs.launchpad.net/bugs/1857158
[ Upstream commit 408d3ba006af57380fa48858b39f72fde6405031 ]

It's not very useful to repeat a bunch of probe deferral errors. And
it's also not very useful to log "failed" without telling the error
code.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/dwc3/core.c

index 03414aca27e7e656eb3d7481134c16d7e89b1c41..1470d0ce10da4fde972ee120a56fdc065f32ca60 100644 (file)
@@ -1249,7 +1249,8 @@ static int dwc3_probe(struct platform_device *pdev)
 
        ret = dwc3_core_init(dwc);
        if (ret) {
-               dev_err(dev, "failed to initialize core\n");
+               if (ret != -EPROBE_DEFER)
+                       dev_err(dev, "failed to initialize core: %d\n", ret);
                goto err4;
        }