]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
selftests: mlxsw: qos_mc_aware: Fix mausezahn invocation
authorPetr Machata <petrm@mellanox.com>
Wed, 15 Jan 2020 11:53:47 +0000 (13:53 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 06:00:53 +0000 (01:00 -0500)
BugLink: https://bugs.launchpad.net/bugs/1862429
commit fef6d6704944c7be72fd2b77c021f1aed3d5df0d upstream.

Mausezahn does not recognize "own" as a keyword on source IP address. As a
result, the MC stream is not running at all, and therefore no UC
degradation can be observed even in principle.

Fix the invocation, and tighten the test: due to the minimum shaper
configured at the MC TCs, we always expect about 20% degradation. Fail the
test if it is lower.

Fixes: 573363a68f27 ("selftests: mlxsw: Add qos_lib.sh")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Reported-by: Amit Cohen <amitc@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh

index 47315fe48d5af51aa0593b0e0546dfff142976ba..24dd8ed485802423be0279166d6735b33f261d71 100755 (executable)
@@ -232,7 +232,7 @@ test_mc_aware()
        stop_traffic
        local ucth1=${uc_rate[1]}
 
-       start_traffic $h1 own bc bc
+       start_traffic $h1 192.0.2.65 bc bc
 
        local d0=$(date +%s)
        local t0=$(ethtool_stats_get $h3 rx_octets_prio_0)
@@ -254,7 +254,11 @@ test_mc_aware()
                        ret = 100 * ($ucth1 - $ucth2) / $ucth1
                        if (ret > 0) { ret } else { 0 }
                    ")
-       check_err $(bc <<< "$deg > 25")
+
+       # Minimum shaper of 200Mbps on MC TCs should cause about 20% of
+       # degradation on 1Gbps link.
+       check_err $(bc <<< "$deg < 15") "Minimum shaper not in effect"
+       check_err $(bc <<< "$deg > 25") "MC traffic degrades UC performance too much"
 
        local interval=$((d1 - d0))
        local mc_ir=$(rate $u0 $u1 $interval)