]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
io-wq: ensure that hash wait lock is IRQ disabling
authorJens Axboe <axboe@kernel.dk>
Tue, 31 Aug 2021 12:57:25 +0000 (06:57 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 31 Aug 2021 17:45:31 +0000 (11:45 -0600)
A previous commit removed the IRQ safety of the worker and wqe locks,
but that left one spot of the hash wait lock now being done without
already having IRQs disabled.

Ensure that we use the right locking variant for the hashed waitqueue
lock.

Fixes: a9a4aa9fbfc5 ("io-wq: wqe and worker locks no longer need to be IRQ safe")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io-wq.c

index 94f8f2ecb8e51d4e8c8c8a5cecf4a3cec63697c0..a94060b72f84f82135f00a8b2e7c4949c8cb6c6c 100644 (file)
@@ -405,7 +405,7 @@ static void io_wait_on_hash(struct io_wqe *wqe, unsigned int hash)
 {
        struct io_wq *wq = wqe->wq;
 
-       spin_lock(&wq->hash->wait.lock);
+       spin_lock_irq(&wq->hash->wait.lock);
        if (list_empty(&wqe->wait.entry)) {
                __add_wait_queue(&wq->hash->wait, &wqe->wait);
                if (!test_bit(hash, &wq->hash->map)) {
@@ -413,7 +413,7 @@ static void io_wait_on_hash(struct io_wqe *wqe, unsigned int hash)
                        list_del_init(&wqe->wait.entry);
                }
        }
-       spin_unlock(&wq->hash->wait.lock);
+       spin_unlock_irq(&wq->hash->wait.lock);
 }
 
 /*