]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
net: fix socket refcounting in skb_complete_tx_timestamp()
authorEric Dumazet <edumazet@google.com>
Sat, 4 Mar 2017 05:01:03 +0000 (21:01 -0800)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 22 Mar 2017 14:02:34 +0000 (08:02 -0600)
commit0fc0f9a55aa5abcb0b8ca78637a725feb0c95286
tree5b936653619c557eb1d090a9c1d04a36c730896c
parentec721f0268d53ba6a693ef2b4da448daa2e9a93c
net: fix socket refcounting in skb_complete_tx_timestamp()

BugLink: http://bugs.launchpad.net/bugs/1675032
[ Upstream commit 9ac25fc063751379cb77434fef9f3b088cd3e2f7 ]

TX skbs do not necessarily hold a reference on skb->sk->sk_refcnt
By the time TX completion happens, sk_refcnt might be already 0.

sock_hold()/sock_put() would then corrupt critical state, like
sk_wmem_alloc and lead to leaks or use after free.

Fixes: 62bccb8cdb69 ("net-timestamp: Make the clone operation stand-alone from phy timestamping")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/core/skbuff.c