]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
ras: mark stub functions as 'inline'
authorArnd Bergmann <arnd@arndb.de>
Tue, 27 Jun 2017 15:35:41 +0000 (17:35 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 9 Aug 2017 14:23:26 +0000 (16:23 +0200)
With CONFIG_RAS disabled, we get two harmless warnings about
unused functions:

include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
 static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
 static void log_non_standard_event(const guid_t *sec_type,

Clearly these are meant to be 'inline', like the other stubs
in the same header.

Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
BugLink: https://launchpad.net/bugs/1696570
Acked-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Will Deacon <will.deacon@arm.com>
(backported from commit 0607512d0a8d7fac86667466b884095e04b10a59)
Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
include/linux/ras.h

index be0ab1cc507109b4833c7d4ba763d1dd5438308d..be26cdd8bcc0e3097b1d69d47f097d601ac1e84e 100644 (file)
@@ -21,11 +21,13 @@ void log_non_standard_event(const uuid_le *sec_type,
                            const u8 sev, const u8 *err, const u32 len);
 void log_arm_hw_error(struct cper_sec_proc_arm *err);
 #else
-static void log_non_standard_event(const uuid_le *sec_type,
+static inline void
+log_non_standard_event(const uuid_le *sec_type,
                                   const uuid_le *fru_id, const char *fru_text,
                                   const u8 sev, const u8 *err,
                                   const u32 len) { return; }
-static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
+static inline void
+log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
 #endif
 
 #endif /* __RAS_H__ */