UBUNTU: SAUCE: scsi: aacraid: Don't copy uninitialized stack memory to userspace

BugLink: http://bugs.launchpad.net/bugs/1700077
Both aac_send_raw_srb() and aac_get_hba_info() may copy stack
allocated structs to userspace without initializing all members
of these structs. Clear out this memory to prevent information
leaks.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index 106b9332f7184e8512f19ac271e3b80fe158d3f7..176220ae69614d5573ca748984e956b56f68449a 100644 (file)
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -949,6 +949,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
                        &((struct aac_native_hba *)srbfib->hw_fib_va)->resp.err;
                struct aac_srb_reply reply;
 
+               memset(&reply, 0, sizeof(reply));
                reply.status = ST_OK;
                if (srbfib->flags & FIB_CONTEXT_FLAG_FASTRESP) {
                        /* fast response */
@@ -1018,6 +1019,7 @@ static int aac_get_hba_info(struct aac_dev *dev, void __user *arg)
 {
        struct aac_hba_info hbainfo;
 
+       memset(&hbainfo, 0, sizeof(hbainfo));
        hbainfo.adapter_number          = (u8) dev->id;
        hbainfo.system_io_bus_number    = dev->pdev->bus->number;
        hbainfo.device_number           = (dev->pdev->devfn >> 3);