]> git.proxmox.com Git - mirror_zfs.git/commit - module/zfs/spa.c
Fix hung z_zvol tasks during 'zfs receive'
authorLOLi <loli10K@users.noreply.github.com>
Fri, 30 Mar 2018 19:10:01 +0000 (21:10 +0200)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Fri, 30 Mar 2018 19:10:01 +0000 (12:10 -0700)
commit77d8a0f1a4d0b2f59cee63088f7987cb38e66538
treef06baa3bdb98f5a4740b66ae60fbbf687cb44ca7
parent2f291ebaed21090afd784f3b376dcb11465a37df
Fix hung z_zvol tasks during 'zfs receive'

During a receive operation zvol_create_minors_impl() can wait
needlessly for the prefetch thread because both share the same tasks
queue.  This results in hung tasks:

<3>INFO: task z_zvol:5541 blocked for more than 120 seconds.
<3>      Tainted: P           O  3.16.0-4-amd64
<3>"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.

The first z_zvol:5541 (zvol_task_cb) is waiting for the long running
traverse_prefetch_thread:260

root@linux:~# cat /proc/spl/taskq
taskq                       act  nthr  spwn  maxt   pri  mina
spl_system_taskq/0            1     2     0    64   100     1
active: [260]traverse_prefetch_thread [zfs](0xffff88003347ae40)
wait: 5541
spl_delay_taskq/0             0     1     0     4   100     1
delay: spa_deadman [zfs](0xffff880039924000)
z_zvol/1                      1     1     0     1   120     1
active: [5541]zvol_task_cb [zfs](0xffff88001fde6400)
pend: zvol_task_cb [zfs](0xffff88001fde6800)

This change adds a dedicated, per-pool, prefetch taskq to prevent the
traverse code from monopolizing the global (and limited) system_taskq by
inappropriately scheduling long running tasks on it.

Reviewed-by: Albert Lee <trisk@forkgnu.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #6330
Closes #6890
Closes #7343
include/sys/spa_impl.h
module/zfs/dmu_traverse.c
module/zfs/spa.c