]> git.proxmox.com Git - mirror_zfs.git/commit - module/zfs/vdev_raidz_math_ssse3.c
Add parity generation/rebuild using 128-bits NEON for Aarch64
authorRomain Dolbeau <romain.github@dolbeau.name>
Mon, 3 Oct 2016 16:44:00 +0000 (18:44 +0200)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 3 Oct 2016 16:44:00 +0000 (09:44 -0700)
commit62a65a654e15a1388bfb571727e69b46e7cc07ab
treea0e0086f3bc025646a1c4bfb6ceb50f869bde8d5
parentd1502e9ed05e0acf46172a4c9791d353f810ea8c
Add parity generation/rebuild using 128-bits NEON for Aarch64

This re-use the framework established for SSE2, SSSE3 and
AVX2. However, GCC is using FP registers on Aarch64, so
unlike SSE/AVX2 we can't rely on the registers being left alone
between ASM statements. So instead, the NEON code uses
C variables and GCC extended ASM syntax. Note that since
the kernel explicitly disable vector registers, they
have to be locally re-enabled explicitly.

As we use the variable's number to define the symbolic
name, and GCC won't allow duplicate symbolic names,
numbers have to be unique. Even when the code is not
going to be used (e.g. the case for 4 registers when
using the macro with only 2). Only the actually used
variables should be declared, otherwise the build
will fails in debug mode.

This requires the replacement of the XOR(X,X) syntax
by a new ZERO(X) macro, which does the same thing but
without repeating the argument. And perhaps someday
there will be a machine where there is a more efficient
way to zero a register than XOR with itself. This affects
scalar, SSE2, SSSE3 and AVX2 as they need the new macro.

It's possible to write faster implementations (different
scheduling, different unrolling, interleaving NEON and
scalar, ...) for various cores, but this one has the
advantage of fitting in the current state of the code,
and thus is likely easier to review/check/merge.

The only difference between aarch64-neon and aarch64-neonx2
is that aarch64-neonx2 unroll some functions some more.

Reviewed-by: Gvozden Neskovic <neskovic@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Romain Dolbeau <romain.dolbeau@atos.net>
Closes #4801
16 files changed:
cmd/raidz_test/raidz_test.h
include/linux/Makefile.am
include/linux/simd_aarch64.h [new file with mode: 0644]
include/sys/vdev_raidz_impl.h
lib/libzpool/Makefile.am
man/man5/zfs-module-parameters.5
module/zfs/Makefile.in
module/zfs/vdev_raidz_math.c
module/zfs/vdev_raidz_math_aarch64_neon.c [new file with mode: 0644]
module/zfs/vdev_raidz_math_aarch64_neon_common.h [new file with mode: 0644]
module/zfs/vdev_raidz_math_aarch64_neonx2.c [new file with mode: 0644]
module/zfs/vdev_raidz_math_avx2.c
module/zfs/vdev_raidz_math_impl.h
module/zfs/vdev_raidz_math_scalar.c
module/zfs/vdev_raidz_math_sse2.c
module/zfs/vdev_raidz_math_ssse3.c