]> git.proxmox.com Git - mirror_zfs.git/commit - tests/zfs-tests/tests/Makefile.am
Fix concurrent resilvers initiated at same time
authorAkash B <akash-b@hpe.com>
Wed, 24 May 2023 19:28:09 +0000 (00:58 +0530)
committerGitHub <noreply@github.com>
Wed, 24 May 2023 19:28:09 +0000 (12:28 -0700)
commit9d618615d1ede4dd40a69386bc300580550fd4d0
tree01e6db019695af07a53ee7558e78ffe2547cf425
parentf8447cf22ec39b2ec3498f0205d4fde3d7efcb27
Fix concurrent resilvers initiated at same time

For draid vdevs it was possible to initiate both the
sequential and healing resilver at same time.

This fixes the following two scenarios.
     1) There's a window where a sequential rebuild can
be started via ZED even if a healing resilver has been
scheduled.
- This is fixed by adding additional check in
spa_vdev_attach() for any scheduled resilver and return
appropriate error code when a resilver is already in
progress.

     2) It was possible for zpool clear to start a healing
resilver when it wasn't needed at all. This occurs because
during a vdev_open() the device is presumed to be healthy not
until the device is validated by vdev_validate() and it's set
unavailable. However, by this point an async resilver will
have already been requested if the DTL isn't empty.
- This is fixed by cancelling the SPA_ASYNC_RESILVER
request immediately at the end of vdev_reopen() when a resilver
is unneeded.

Finally, added a testcase in ZTS for verification.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Dipak Ghosh <dipak.ghosh@hpe.com>
Signed-off-by: Akash B <akash-b@hpe.com>
Closes #14881
Closes #14892
module/zfs/spa.c
module/zfs/vdev.c
tests/runfiles/common.run
tests/zfs-tests/tests/Makefile.am
tests/zfs-tests/tests/functional/cli_root/zpool_resilver/zpool_resilver_concurrent.ksh [new file with mode: 0755]