]> git.proxmox.com Git - mirror_zfs.git/commit
Skip import activity test in more zdb code paths
authorOlaf Faaland <faaland1@llnl.gov>
Mon, 20 Aug 2018 17:05:23 +0000 (10:05 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Mon, 20 Aug 2018 17:05:23 +0000 (10:05 -0700)
commit34fe773e303e499e6a6e5fcd2ceeee4531579dab
tree2871fe497c6ce4ee775411d13f8b5d011564e8bf
parentedc05fdb34792e65508ac2ff91c58828b44f19b1
Skip import activity test in more zdb code paths

Since zdb opens the pools read-only, it cannot damage the pool in the
event the pool is already imported either on the same host or on
another one.

If the pool vdev structure is changing while zdb is importing the
pool, it may cause zdb to crash.  However this is unlikely, and in any
case it's a user space process and can simply be run again.

For this reason, zdb should disable the multihost activity test on
import that is normally run.

This commit fixes a few zdb code paths where that had been overlooked.
It also adds tests to ensure that several common use cases handle this
properly in the future.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Gu Zheng <guzheng2331314@163.com>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes #7797
Closes #7801
cmd/zdb/zdb.c
tests/runfiles/linux.run
tests/zfs-tests/tests/functional/mmp/Makefile.am
tests/zfs-tests/tests/functional/mmp/mmp_on_zdb.ksh [new file with mode: 0755]