]> git.proxmox.com Git - mirror_zfs.git/commit
Fix nfs_truncate_shares without /etc/exports.d
authorsiv0 <github@nomore.at>
Tue, 31 Oct 2023 20:57:54 +0000 (21:57 +0100)
committerGitHub <noreply@github.com>
Tue, 31 Oct 2023 20:57:54 +0000 (13:57 -0700)
commit41e55b476bcfc90f1ad81c02c5375367fdace9e9
tree7873d9e5dd2dded5e5339d618a6485b430106930
parent763ca47fa81808be62ab5e02357e896233f24abc
Fix nfs_truncate_shares without /etc/exports.d

Calling nfs_reset_shares on Linux prints a warning:
`failed to lock /etc/exports.d/zfs.exports.lock: No such file or
directory`
when /etc/exports.d does not exist. The directory gets created, when a
filesystem is actually exported through nfs_toggle_share and
nfs_init_share. The truncation of /etc/exports.d/zfs.exports happens
unconditionally when calling `zfs mount -a` (via zfs_do_mount and
share_mount in `cmd/zfs/zfs_main.c`).

Fixing the issue only in the Linux part, since the exports file on
freebsd is in `/etc/zfs/`, which seems present on 2 FreeBSD systems I
have access to (through `/etc/zfs/compatibility.d/`), while a Debian
box does not have the directory even if `/usr/sbin/exportfs` is
present through the `nfs-kernel-server` package.

The code for exports_available is copied from nfs_available above.

Fixes: ede037cda73675f42b1452187e8dd3438fafc220
("Make zfs-share service resilient to stale exports")

Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Closes #15369
Closes #15468
lib/libshare/os/linux/nfs.c