]> git.proxmox.com Git - mirror_zfs.git/commit
Increase default zcmd allocation to 256K
authorMichael Niewöhner <c0d3z3r0@users.noreply.github.com>
Tue, 30 Jul 2019 16:59:38 +0000 (18:59 +0200)
committerMatthew Ahrens <mahrens@delphix.com>
Tue, 30 Jul 2019 16:59:38 +0000 (09:59 -0700)
commit85ce79bbc8cf17f100eb4ae6a0d1b1ce2e2dd9d9
tree0d88807149003012ff6a59f3ab32fe9ef1ca74d2
parent0eb8ba6ab68801d4b0e6280e7388514a6355fc86
Increase default zcmd allocation to 256K

When creating hundreds of clones (for example using containers with
LXD) cloning slows down as the number of clones increases over time.
The reason for this is that the fetching of the clone information
using a small zcmd buffer requires two ioctl calls, one to determine
the size and a second to return the data. However, this requires
gathering the data twice, once to determine the size and again to
populate the zcmd buffer to return it to userspace.
These are expensive ioctl() calls, so instead, make the default buffer
size much larger: 256K.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Closes #9084
lib/libzfs/libzfs_util.c