]> git.proxmox.com Git - mirror_zfs.git/commit
Change the error handling for invalid property values
authorAllan Jude <allan@klarasystems.com>
Sat, 1 Aug 2020 15:41:31 +0000 (11:41 -0400)
committerGitHub <noreply@github.com>
Sat, 1 Aug 2020 15:41:31 +0000 (08:41 -0700)
commit8fb79fdddb076036a006e19f4e1b93b3baf72498
tree9327b9f3a9b6dd1efb12778e74de7a34567f1856
parent47ed79ff60945e0c5d8ccb56f0d29a893e1261ac
Change the error handling for invalid property values

ZFS recv should return a useful error message when an invalid index
property value is provided in the send stream properties nvlist

With a compression= property outside of the understood range:

Before:
```
receiving full stream of zof/zstd_send@send2 into testpool/recv@send2
internal error: Invalid argument
Aborted (core dumped)
```
Note: the recv completes successfully, the abort() is likely just to
make it easier to track the unexpected error code.

After:
```
receiving full stream of zof/zstd_send@send2 into testpool/recv@send2
cannot receive compression property on testpool/recv: invalid property
value received 28.9M stream in 1 seconds (28.9M/sec)
```

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #10631
contrib/pyzfs/libzfs_core/_constants.py
contrib/pyzfs/libzfs_core/_error_translation.py
include/sys/fs/zfs.h
lib/libzfs/libzfs_util.c
module/zfs/zfs_ioctl.c