]> git.proxmox.com Git - mirror_zfs.git/commit
fix: variable type with zfs-tests/cmd/clonefile.c
authorTino Reichardt <milky-zfs@mcmilk.de>
Wed, 17 Jan 2024 17:06:14 +0000 (18:06 +0100)
committerGitHub <noreply@github.com>
Wed, 17 Jan 2024 17:06:14 +0000 (09:06 -0800)
commita0b2a93c41b0b0d7723d1b20eb1eca7a1a63e45b
treea8e52598c15a8bc36b56ea17ef1defd910ad6e66
parente3d3d772de1cfc02d1df26bc6aadbbc48a28dcff
fix: variable type with zfs-tests/cmd/clonefile.c

Compiling on arm64 freebsd-13.2 and arm64 almalinux-8 brings currently
this error:

```
  CC       tests/zfs-tests/cmd/clonefile.o
tests/zfs-tests/cmd/clonefile.c:166:43: error: result of comparison of \
constant -1 with expression of type 'char' is always true \
[-Werror,-Wtautological-constant-out-of-range-compare]
        while ((c = getopt(argc, argv, "crfdq")) != -1) {
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
1 error generated.
gmake[2]: *** [Makefile:8675: tests/zfs-tests/cmd/clonefile.o] Error 1
```

Fix: use correct variable type `int`.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #15783
tests/zfs-tests/cmd/clonefile.c