]> git.proxmox.com Git - mirror_zfs.git/commit
libzfs: Fail making a dataset handle gracefully
authorRyan Moeller <ryan@iXsystems.com>
Fri, 18 Feb 2022 21:09:03 +0000 (16:09 -0500)
committerGitHub <noreply@github.com>
Fri, 18 Feb 2022 21:09:03 +0000 (13:09 -0800)
commite41013078a90d5790c737eec573ec376ca21a234
tree226e3cc7cd664a8354f8d19b9c578c48ac746916
parenta014378dd010fb4f9bf5ab003bd27526ff898952
libzfs: Fail making a dataset handle gracefully

When a dataset is in the process of being received it gets marked as
inconsistent and should not be used.  We should check for this when
opening a dataset handle in libzfs and return with an appropriate error
set, rather than hitting an abort because of the incomplete data.

zfs_open() passes errno to zfs_standard_error() after observing
make_dataset_handle() fail, which ends up aborting if errno is 0.
Set errno before returning where we know it has not been set already.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #13077
lib/libzfs/libzfs_dataset.c