]> git.proxmox.com Git - mirror_zfs.git/commit
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode
authorAllan Jude <allan@klarasystems.com>
Thu, 16 Dec 2021 19:56:22 +0000 (14:56 -0500)
committerGitHub <noreply@github.com>
Thu, 16 Dec 2021 19:56:22 +0000 (11:56 -0800)
commitf6a0dac84af2fba9c306a3a307ea7aafcbe32d2b
treea60d820228fe669dacc8f1687251fcc98a22c621
parent2300621dc7450adccf86ddbf397c72f8e5e2d76c
zfs list: Allow more fields in ZFS_ITER_SIMPLE mode

If the fields to be listed and sorted by are constrained
to those populated by dsl_dataset_fast_stat(), then
zfs list is much faster, as it does not need to open each
objset and reads its properties.

A previous optimization by Pawel Dawidek
(0cee24064a79f9c01fc4521543c37acea538405f) took advantage
of this to make listing snapshot names sorted only by name
much faster.

However, it was limited to `-o name -s name`, this work
extends this optimization to work with:
  - name
  - guid
  - createtxg
  - numclones
  - inconsistent
  - redacted
  - origin
and could be further extended to any other properties
supported by dsl_dataset_fast_stat() or similar, that do
not require extra locking or reading from disk.

Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #11080
14 files changed:
cmd/zfs/zfs_iter.c
cmd/zfs/zfs_iter.h
cmd/zfs/zfs_main.c
cmd/zpool/zpool_main.c
contrib/pam_zfs_key/pam_zfs_key.c
include/libzfs.h
lib/libzfs/libzfs.abi
lib/libzfs/libzfs_changelist.c
lib/libzfs/libzfs_crypto.c
lib/libzfs/libzfs_dataset.c
lib/libzfs/libzfs_iter.c
lib/libzfs/libzfs_mount.c
lib/libzfs/libzfs_sendrecv.c
module/zfs/zfs_ioctl.c