]> git.proxmox.com Git - mirror_zfs.git/commit
contrib: bash_completion.d: make install destination vendor dependent
authorStoiko Ivanov <s.ivanov@proxmox.com>
Wed, 20 Sep 2023 17:33:14 +0000 (19:33 +0200)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Tue, 3 Oct 2023 00:05:59 +0000 (17:05 -0700)
commite69ade32e116e72d03068c03799924c3f1a15c95
tree68b9cffd40103f213e3b452eb3de5056b0a3f2a4
parent4e16964e1c1555704f6e7cd031ae32e1491f0b11
contrib: bash_completion.d: make install destination vendor dependent

Certain Linux distributions (Debian/Ubuntu at least) expect
bash-completion snippets to be installed in
/usr/share/bash-completion/completions instead of
/etc/bash_completion.d.

This patch sets the bashcompletiondir variable based on the vendor,
inspired by similar settings for initdir and initconfdir.

It seems that commit 612b8dff5bc3d827efb864a199a62bda1a419254
caused the file to be installed in the first-place (thus the error
when building debian packages only became apparent when testing a
2.2.0-rc4 build)

The change only sets the variable in Makefile context - the
rpm/zfs.spec.in file has the path hardcoded as
%{_sysconfdir}/bash_completion.d/zfs, but since running
```
./configure --sysconfdir=/myetc  ; make rpm
```
also results in all relevant files to be installed in /etc instead of
/myetc I assume this can remain as is.

Reviewed-by: Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Closes #15304
config/zfs-build.m4
contrib/bash_completion.d/Makefile.am