]> git.proxmox.com Git - ovs.git/commitdiff
compat: Remove unused function
authorGreg Rose <gvrose8192@gmail.com>
Fri, 31 Aug 2018 17:26:47 +0000 (10:26 -0700)
committerBen Pfaff <blp@ovn.org>
Fri, 31 Aug 2018 19:36:17 +0000 (12:36 -0700)
The compat function rpl_nf_conntrack_in() does not appear to be used
anywhere and emits warnings as such during builds < 4.10.

The patch passes Travis:

https://travis-ci.org/gvrose8192/ovs-experimental/builds/423097292

Remove it.

Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
datapath/linux/compat/include/net/netfilter/nf_conntrack_core.h

index 715e1d51014e63b03357a0a54a9390a58ea02186..7834c8c25f797adfcb3853ecf43f04cf4f3850d7 100644 (file)
@@ -67,27 +67,6 @@ static inline bool rpl_nf_ct_get_tuple(const struct sk_buff *skb,
 #define nf_ct_get_tuple rpl_nf_ct_get_tuple
 #endif /* HAVE_NF_CT_GET_TUPLEPR_TAKES_STRUCT_NET */
 
-/* Commit 08733a0cb7de ("netfilter: handle NF_REPEAT from nf_conntrack_in()")
- * introduced behavioural changes to this function which cannot be detected
- * in the headers. Unconditionally backport to kernels older than the one which
- * contains this commit. */
-#if LINUX_VERSION_CODE < KERNEL_VERSION(4,10,0)
-static unsigned int rpl_nf_conntrack_in(struct net *net, u_int8_t pf,
-                                       unsigned int hooknum,
-                                       struct sk_buff *skb)
-{
-       int err;
-
-       /* Repeat if requested, see nf_iterate(). */
-       do {
-               err = nf_conntrack_in(net, pf, hooknum, skb);
-       } while (err == NF_REPEAT);
-
-       return err;
-}
-#define nf_conntrack_in rpl_nf_conntrack_in
-#endif /* < 4.10 */
-
 #ifdef HAVE_NF_CONN_TIMER
 
 #ifndef HAVE_NF_CT_DELETE