]> git.proxmox.com Git - ovs.git/commitdiff
compat: Clean up tunnel_id_to_key
authorGreg Rose <gvrose8192@gmail.com>
Wed, 3 Jul 2019 17:04:55 +0000 (10:04 -0700)
committerBen Pfaff <blp@ovn.org>
Wed, 3 Jul 2019 18:16:23 +0000 (11:16 -0700)
This function was just a duplicate of tunnel_id_to_key32 - I'm not sure
why it was ever needed but let's dump it now.

Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Acked-by: William Tu <u9012063@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
datapath/linux/compat/ip_gre.c

index 6766661508740e81c7c6c312a0a241a44268eb7f..2015d597c04689cfc02bbca7386b306871af45ae 100644 (file)
@@ -71,16 +71,6 @@ static void erspan_build_header(struct sk_buff *skb,
 
 static bool ip_gre_loaded = false;
 
-/* Returns the least-significant 32 bits of a __be64. */
-static __be32 tunnel_id_to_key(__be64 x)
-{
-#ifdef __BIG_ENDIAN
-       return (__force __be32)x;
-#else
-       return (__force __be32)((__force u64)x >> 32);
-#endif
-}
-
 /* Normally in net/core/dst.c but move it here */
 struct dst_ops md_dst_ops = {
        .family =               AF_UNSPEC,
@@ -474,7 +464,7 @@ netdev_tx_t rpl_gre_fb_xmit(struct sk_buff *skb)
 
        flags = tun_info->key.tun_flags & (TUNNEL_CSUM | TUNNEL_KEY);
        build_header(skb, tunnel_hlen, flags, htons(ETH_P_TEB),
-                    tunnel_id_to_key(tun_info->key.tun_id), 0);
+                    tunnel_id_to_key32(tun_info->key.tun_id), 0);
 
        df = key->tun_flags & TUNNEL_DONT_FRAGMENT ?  htons(IP_DF) : 0;
        iptunnel_xmit(skb->sk, rt, skb, fl.saddr, key->u.ipv4.dst, IPPROTO_GRE,