form: filter field: code cleanups

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/js/form/FilterField.js b/js/form/FilterField.js
index ee804c5ca8129d1011ed69f1efb92f98e7f720d3..1d9972217c7c0e73b1994f096ecac7bf5f368d54 100644 (file)
--- a/js/form/FilterField.js
+++ b/js/form/FilterField.js
@@ -35,21 +35,18 @@ Ext.define('PMG.form.FilterField', {
            }
 
            me.store.clearFilter();
-           field.triggers.clear.setVisible(false);
+           field.triggers.clear.setVisible(value.length > 0);
+
            if (value) {
                me.store.filterBy((rec) => me.filteredFields.some((fieldDef) => {
-                   let fieldname, renderer;
+                   let fieldname = fieldDef, renderer = Ext.identityFn;
                    if (Ext.isObject(fieldDef)) {
                        fieldname = fieldDef.name;
                        renderer = fieldDef.renderer;
-                   } else {
-                       fieldname = fieldDef;
-                       renderer = Ext.identityFn;
                    }
                    let testedValue = renderer(rec.data[fieldname]);
                    return testedValue.toString().toLowerCase().indexOf(value.toLowerCase()) !== -1;
                }));
-               field.triggers.clear.setVisible(true);
            }
        },
     },