]> git.proxmox.com Git - pmg-gui.git/commitdiff
quarantines: color code deliver and delete buttons
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Sat, 22 Oct 2022 14:16:39 +0000 (16:16 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Sat, 22 Oct 2022 14:16:41 +0000 (16:16 +0200)
In some languages, e.g. widely used English, "Delete" and "Deliver"
are looking rather similar without too much eye squinting required.

Add an accent on their icons using for, at least in the western
hemisphere, the respective associated color, like red for trash can.
To 1) avoid to much messing with those cultures that got it switched
and 2) some more common color blindness use blue for the delivery
button, just to make it stand out.

Keep the white/black list as is, as such accents work best if not
everything uses them, i.e., so that they more common options actually
stand out.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
js/AttachmentQuarantine.js
js/QuarantineContextMenu.js
js/SpamContextMenu.js
js/SpamQuarantine.js
js/VirusQuarantine.js

index b295448bc1d5e510cc2d604471b499d572d537a0..1e5642067d5203beaece51ab5b8bbcd022b8e4d1 100644 (file)
@@ -166,13 +166,13 @@ Ext.define('PMG.AttachmentQuarantine', {
                        {
                            reference: 'deliver',
                            text: gettext('Deliver'),
-                           iconCls: 'fa fa-paper-plane-o',
+                           iconCls: 'fa fa-paper-plane-o info-blue',
                            handler: 'btnHandler',
                        },
                        {
                            reference: 'delete',
                            text: gettext('Delete'),
-                           iconCls: 'fa fa-trash-o',
+                           iconCls: 'fa fa-trash-o critical',
                            handler: 'btnHandler',
                        },
                    ],
index 4f7744ed200091b9d76420126f16846277b5a522..966767a80104f110c2fde80b444271de0028eceb 100644 (file)
@@ -17,13 +17,13 @@ Ext.define('PMG.menu.QuarantineContextMenu', {
     items: [
        {
            text: gettext('Deliver'),
-           iconCls: 'fa fa-fw fa-paper-plane-o',
+           iconCls: 'fa fa-fw fa-paper-plane-o good',
            action: 'deliver',
            handler: 'callCallback',
        },
        {
            text: gettext('Delete'),
-           iconCls: 'fa fa-fw fa-trash-o',
+           iconCls: 'fa fa-fw fa-trash-o critical',
            action: 'delete',
            handler: 'callCallback',
        },
index b089f0f27f9a71049376e63e76c07d4de696e000..01064976c8aee2c1132321a84900482d149c10f9 100644 (file)
@@ -4,13 +4,13 @@ Ext.define('PMG.menu.SpamContextMenu', {
     items: [
        {
            text: gettext('Deliver'),
-           iconCls: 'fa fa-fw fa-paper-plane-o',
+           iconCls: 'fa fa-fw fa-paper-plane-o info-blue',
            action: 'deliver',
            handler: 'callCallback',
        },
        {
            text: gettext('Delete'),
-           iconCls: 'fa fa-fw fa-trash-o',
+           iconCls: 'fa fa-fw fa-trash-o critical',
            action: 'delete',
            handler: 'callCallback',
        },
index 7b25e48719754fb34361c351b668605f77952d12..6fe20d7ac48c240d983881f103731ce17b161027 100644 (file)
@@ -364,13 +364,13 @@ Ext.define('PMG.SpamQuarantine', {
                        {
                            reference: 'deliver',
                            text: gettext('Deliver'),
-                           iconCls: 'fa fa-paper-plane-o',
+                           iconCls: 'fa fa-paper-plane-o info-blue',
                            handler: 'btnHandler',
                        },
                        {
                            reference: 'delete',
                            text: gettext('Delete'),
-                           iconCls: 'fa fa-trash-o',
+                           iconCls: 'fa fa-trash-o critical',
                            handler: 'btnHandler',
                        },
                    ],
index e6274903d3645972fabdd5d2bf369a7d3dedd4ae..4c1d0ba9f34038753bd4a404edb083f6fbd61944 100644 (file)
@@ -175,13 +175,13 @@ Ext.define('PMG.VirusQuarantine', {
                        {
                            reference: 'deliver',
                            text: gettext('Deliver'),
-                           iconCls: 'fa fa-paper-plane-o',
+                           iconCls: 'fa fa-paper-plane-o info-blue',
                            handler: 'btnHandler',
                        },
                        {
                            reference: 'delete',
                            text: gettext('Delete'),
-                           iconCls: 'fa fa-trash-o',
+                           iconCls: 'fa fa-trash-o critical',
                            handler: 'btnHandler',
                        },
                    ],