ui: form/GroupFilter: improve group load callback handling

if 'me' is already destroyed here, return
if records is 'null' (which can happen on a not successful load),
load an empty list instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/form/GroupFilter.js b/www/form/GroupFilter.js
index 5c75f1d006e26e50386172d77f81b86cb25d0724..11aa24c4fff0f07b63152a8917f6de892c9c9cac 100644 (file)
--- a/www/form/GroupFilter.js
+++ b/www/form/GroupFilter.js
@@ -214,8 +214,11 @@ Ext.define('PBS.form.GroupFilter', {
        me.setDsStoreUrl(url);
        me.dsStore.load({
            callback: (records) => {
+               if (me.isDestroyed) {
+                   return;
+               }
                me.query('pbsGroupSelector').forEach((selector) => {
-                   selector.getStore().setData(records);
+                   selector.getStore().setData(records || []);
                });
            },
        });