dns: optionally send delete for optional values

pbs only deletes the optional values here when they are sent with the
'delete' parameter, in contrast to pve/pmg that don't have a delete
parameter currently and always use the parameters as source of truth.

So to handle that, optionally set deleteEmpty if set from outside

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/src/node/DNSEdit.js b/src/node/DNSEdit.js
index 0b1135ed5f4bf2c7df12827ea56f3e70423121b1..c895d9bb1ed60a7c4f14831bfaa35c75fe9328b7 100644 (file)
--- a/src/node/DNSEdit.js
+++ b/src/node/DNSEdit.js
@@ -2,6 +2,9 @@ Ext.define('Proxmox.node.DNSEdit', {
     extend: 'Proxmox.window.Edit',
     alias: ['widget.proxmoxNodeDNSEdit'],
 
+    // pbs needs this set to true
+    deleteEmpty: false,
+
     initComponent: function() {
        let me = this;
 
@@ -21,6 +24,7 @@ Ext.define('Proxmox.node.DNSEdit', {
                 fieldLabel: gettext('DNS server') + " 1",
                vtype: 'IP64Address',
                skipEmptyText: true,
+               deleteEmpty: me.deleteEmpty,
                 name: 'dns1',
            },
            {
@@ -28,6 +32,7 @@ Ext.define('Proxmox.node.DNSEdit', {
                fieldLabel: gettext('DNS server') + " 2",
                vtype: 'IP64Address',
                skipEmptyText: true,
+               deleteEmpty: me.deleteEmpty,
                 name: 'dns2',
            },
            {
@@ -35,6 +40,7 @@ Ext.define('Proxmox.node.DNSEdit', {
                 fieldLabel: gettext('DNS server') + " 3",
                vtype: 'IP64Address',
                skipEmptyText: true,
+               deleteEmpty: me.deleteEmpty,
                 name: 'dns3',
            },
        ];

diff --git a/src/node/DNSView.js b/src/node/DNSView.js
index 4782f9c4f1aa0a44323fb460e9199f6e5da91800..b57da85b37482cb869f8381c6bc7e5f3139ee3da 100644 (file)
--- a/src/node/DNSView.js
+++ b/src/node/DNSView.js
@@ -2,6 +2,9 @@ Ext.define('Proxmox.node.DNSView', {
     extend: 'Proxmox.grid.ObjectGrid',
     alias: ['widget.proxmoxNodeDNSView'],
 
+    // pbs needs this set to true
+    deleteEmpty: false,
+
     initComponent: function() {
        let me = this;
 
@@ -12,6 +15,7 @@ Ext.define('Proxmox.node.DNSView', {
        let run_editor = () => Ext.create('Proxmox.node.DNSEdit', {
            autoShow: true,
            nodename: me.nodename,
+           deleteEmpty: me.deleteEmpty,
        });
 
        Ext.apply(me, {