1 package PVE
::AccessControl
;
5 use Crypt
::OpenSSL
::Random
;
6 use Crypt
::OpenSSL
::RSA
;
9 use PVE
::Tools
qw(run_command lock_file file_get_contents split_list safe_print);
10 use PVE
::Cluster
qw(cfs_register_file cfs_read_file cfs_write_file cfs_lock_file);
13 use PVE
::Auth
::Plugin
;
19 use Data
::Dumper
; # fixme: remove
21 # load and initialize all plugins
23 PVE
::Auth
::AD-
>register();
24 PVE
::Auth
::LDAP-
>register();
25 PVE
::Auth
::PVE-
>register();
26 PVE
::Auth
::PAM-
>register();
27 PVE
::Auth
::Plugin-
>init();
29 # $authdir must be writable by root only!
30 my $confdir = "/etc/pve";
31 my $authdir = "$confdir/priv";
32 my $authprivkeyfn = "$authdir/authkey.key";
33 my $authpubkeyfn = "$confdir/authkey.pub";
34 my $pve_www_key_fn = "$confdir/pve-www.key";
36 my $ticket_lifetime = 3600*2; # 2 hours
38 Crypt
::OpenSSL
::RSA-
>import_random_seed();
40 cfs_register_file
('user.cfg',
46 PVE
::Auth
::Plugin
::verify_username
(@_);
49 sub pve_verify_realm
{
50 PVE
::Auth
::Plugin
::pve_verify_realm
(@_);
53 sub lock_user_config
{
54 my ($code, $errmsg) = @_;
56 cfs_lock_file
("user.cfg", undef, $code);
58 $errmsg ?
die "$errmsg: $err" : die $err;
65 return $pve_auth_pub_key if $pve_auth_pub_key;
67 my $input = PVE
::Tools
::file_get_contents
($authpubkeyfn);
69 $pve_auth_pub_key = Crypt
::OpenSSL
::RSA-
>new_public_key($input);
71 return $pve_auth_pub_key;
74 my $csrf_prevention_secret;
75 my $get_csrfr_secret = sub {
76 if (!$csrf_prevention_secret) {
77 my $input = PVE
::Tools
::file_get_contents
($pve_www_key_fn);
78 $csrf_prevention_secret = Digest
::SHA
::sha1_base64
($input);
80 return $csrf_prevention_secret;
83 sub assemble_csrf_prevention_token
{
86 my $timestamp = sprintf("%08X", time());
88 my $digest = Digest
::SHA
::sha1_base64
("$timestamp:$username", &$get_csrfr_secret());
90 return "$timestamp:$digest";
93 sub verify_csrf_prevention_token
{
94 my ($username, $token, $noerr) = @_;
96 if ($token =~ m/^([A-Z0-9]{8}):(\S+)$/) {
99 my $ttime = hex($timestamp);
101 my $digest = Digest
::SHA
::sha1_base64
("$timestamp:$username", &$get_csrfr_secret());
103 my $age = time() - $ttime;
104 return if ($digest eq $sig) && ($age > -300) && ($age < $ticket_lifetime);
107 die "Permission denied - invalid csrf token\n" if !$noerr;
112 my $pve_auth_priv_key;
115 return $pve_auth_priv_key if $pve_auth_priv_key;
117 my $input = PVE
::Tools
::file_get_contents
($authprivkeyfn);
119 $pve_auth_priv_key = Crypt
::OpenSSL
::RSA-
>new_private_key($input);
121 return $pve_auth_priv_key;
124 sub assemble_ticket
{
127 my $rsa_priv = get_privkey
();
129 my $timestamp = sprintf("%08X", time());
131 my $plain = "PVE:$username:$timestamp";
133 my $ticket = $plain . "::" . encode_base64
($rsa_priv->sign($plain), '');
139 my ($ticket, $noerr) = @_;
141 if ($ticket && $ticket =~ m/^(PVE:\S+)::([^:\s]+)$/) {
145 my $rsa_pub = get_pubkey
();
146 if ($rsa_pub->verify($plain, decode_base64
($sig))) {
147 if ($plain =~ m/^PVE:(\S+):([A-Z0-9]{8})$/) {
150 my $ttime = hex($timestamp);
152 my $age = time() - $ttime;
154 if (PVE
::Auth
::Plugin
::verify_username
($username, 1) &&
155 ($age > -300) && ($age < $ticket_lifetime)) {
156 return wantarray ?
($username, $age) : $username;
162 die "permission denied - invalid ticket\n" if !$noerr;
168 # - they do not contain the username in plain text
169 # - they are restricted to a specific resource path (example: '/vms/100')
170 sub assemble_vnc_ticket
{
171 my ($username, $path) = @_;
173 my $rsa_priv = get_privkey
();
175 my $timestamp = sprintf("%08X", time());
177 my $plain = "PVEVNC:$timestamp";
179 $path = normalize_path
($path);
181 my $full = "$plain:$username:$path";
183 my $ticket = $plain . "::" . encode_base64
($rsa_priv->sign($full), '');
188 sub verify_vnc_ticket
{
189 my ($ticket, $username, $path, $noerr) = @_;
191 if ($ticket && $ticket =~ m/^(PVEVNC:\S+)::([^:\s]+)$/) {
194 my $full = "$plain:$username:$path";
196 my $rsa_pub = get_pubkey
();
197 # Note: sign only match if $username and $path is correct
198 if ($rsa_pub->verify($full, decode_base64
($sig))) {
199 if ($plain =~ m/^PVEVNC:([A-Z0-9]{8})$/) {
202 my $age = time() - $ttime;
204 if (($age > -20) && ($age < 40)) {
211 die "permission denied - invalid vnc ticket\n" if !$noerr;
216 sub assemble_spice_ticket
{
217 my ($username, $path) = @_;
219 my $rsa_priv = get_privkey
();
221 my $timestamp = sprintf("%08X", time());
223 my $plain = "PVESPICE:$timestamp";
225 $path = normalize_path
($path);
227 my $full = "$plain:$path";
229 my $ticket = $plain . "::" . encode_base64
($rsa_priv->sign($full), '');
234 sub check_user_exist
{
235 my ($usercfg, $username, $noerr) = @_;
237 $username = PVE
::Auth
::Plugin
::verify_username
($username, $noerr);
238 return undef if !$username;
240 return $usercfg->{users
}->{$username} if $usercfg && $usercfg->{users
}->{$username};
242 die "no such user ('$username')\n" if !$noerr;
247 sub check_user_enabled
{
248 my ($usercfg, $username, $noerr) = @_;
250 my $data = check_user_exist
($usercfg, $username, $noerr);
251 return undef if !$data;
253 return 1 if $data->{enable
};
255 return 1 if $username eq 'root@pam'; # root is always enabled
257 die "user '$username' is disabled\n" if !$noerr;
262 # password should be utf8 encoded
263 sub authenticate_user
{
264 my ($username, $password) = @_;
266 die "no username specified\n" if !$username;
270 ($username, $ruid, $realm) = PVE
::Auth
::Plugin
::verify_username
($username);
272 my $usercfg = cfs_read_file
('user.cfg');
274 eval { check_user_enabled
($usercfg, $username); };
281 my $expire = $usercfg->{users
}->{$username}->{expire
};
283 if ($expire && ($expire < $ctime)) {
285 die "account expired\n"
288 my $domain_cfg = cfs_read_file
('domains.cfg');
291 my $cfg = $domain_cfg->{ids
}->{$realm};
292 die "auth domain '$realm' does not exists\n" if !$cfg;
293 my $plugin = PVE
::Auth
::Plugin-
>lookup($cfg->{type
});
294 $plugin->authenticate_user($cfg, $realm, $ruid, $password);
297 sleep(2); # timeout after failed auth
304 sub domain_set_password
{
305 my ($realm, $username, $password) = @_;
307 die "no auth domain specified" if !$realm;
309 my $domain_cfg = cfs_read_file
('domains.cfg');
311 my $cfg = $domain_cfg->{ids
}->{$realm};
312 die "auth domain '$realm' does not exists\n" if !$cfg;
313 my $plugin = PVE
::Auth
::Plugin-
>lookup($cfg->{type
});
314 $plugin->store_password($cfg, $realm, $username, $password);
319 my ($username, $usercfg, $group) = @_;
320 $usercfg->{users
}->{$username}->{groups
}->{$group} = 1;
321 $usercfg->{groups
}->{$group}->{users
}->{$username} = 1;
324 sub delete_user_group
{
326 my ($username, $usercfg) = @_;
328 foreach my $group (keys %{$usercfg->{groups
}}) {
330 delete ($usercfg->{groups
}->{$group}->{users
}->{$username})
331 if $usercfg->{groups
}->{$group}->{users
}->{$username};
335 sub delete_user_acl
{
337 my ($username, $usercfg) = @_;
339 foreach my $acl (keys %{$usercfg->{acl
}}) {
341 delete ($usercfg->{acl
}->{$acl}->{users
}->{$username})
342 if $usercfg->{acl
}->{$acl}->{users
}->{$username};
346 sub delete_group_acl
{
348 my ($group, $usercfg) = @_;
350 foreach my $acl (keys %{$usercfg->{acl
}}) {
352 delete ($usercfg->{acl
}->{$acl}->{groups
}->{$group})
353 if $usercfg->{acl
}->{$acl}->{groups
}->{$group};
357 sub delete_pool_acl
{
359 my ($pool, $usercfg) = @_;
361 my $path = "/pool/$pool";
363 foreach my $aclpath (keys %{$usercfg->{acl
}}) {
364 delete ($usercfg->{acl
}->{$aclpath})
365 if $usercfg->{acl
}->{$aclpath} eq 'path';
369 # we automatically create some predefined roles by splitting privs
370 # into 3 groups (per category)
371 # root: only root is allowed to do that
372 # admin: an administrator can to that
373 # user: a normak user/customer can to that
383 'VM.Config.Options', # covers all other things
391 'VM.Config.CDROM', # change CDROM media
403 'Sys.Modify', # edit/change node settings
406 'Permissions.Modify',
418 'Datastore.Allocate',
419 'Datastore.AllocateTemplate',
422 'Datastore.AllocateSpace',
434 'Group.Allocate', # edit/change group settings
435 'Realm.AllocateUser',
443 'Pool.Allocate', # create/delete pools
450 my $valid_privs = {};
452 my $special_roles = {
453 'NoAccess' => {}, # no priviledges
454 'Administrator' => $valid_privs, # all priviledges
459 foreach my $cat (keys %$privgroups) {
460 my $cd = $privgroups->{$cat};
461 foreach my $p (@{$cd->{root
}}, @{$cd->{admin
}},
462 @{$cd->{user
}}, @{$cd->{audit
}}) {
463 $valid_privs->{$p} = 1;
465 foreach my $p (@{$cd->{admin
}}, @{$cd->{user
}}, @{$cd->{audit
}}) {
467 $special_roles->{"PVE${cat}Admin"}->{$p} = 1;
468 $special_roles->{"PVEAdmin"}->{$p} = 1;
470 if (scalar(@{$cd->{user
}})) {
471 foreach my $p (@{$cd->{user
}}, @{$cd->{audit
}}) {
472 $special_roles->{"PVE${cat}User"}->{$p} = 1;
475 foreach my $p (@{$cd->{audit
}}) {
476 $special_roles->{"PVEAuditor"}->{$p} = 1;
480 $special_roles->{"PVETemplateUser"} = { 'VM.Clone' => 1, 'VM.Audit' => 1 };
486 my ($role, $usercfg, $privs) = @_;
490 die "role '$role' does not exist\n" if !$usercfg->{roles
}->{$role};
492 foreach my $priv (split_list
($privs)) {
493 if (defined ($valid_privs->{$priv})) {
494 $usercfg->{roles
}->{$role}->{$priv} = 1;
496 die "invalid priviledge '$priv'\n";
508 $path = '/' if !$path;
510 $path = "/$path" if $path !~ m
|^/|;
512 return undef if $path !~ m
|^[[:alnum
:]\
-\_\
/]+$|;
518 PVE
::JSONSchema
::register_format
('pve-groupid', \
&verify_groupname
);
519 sub verify_groupname
{
520 my ($groupname, $noerr) = @_;
522 if ($groupname !~ m/^[A-Za-z0-9\.\-_]+$/) {
524 die "group name '$groupname' contains invalid characters\n" if !$noerr;
532 PVE
::JSONSchema
::register_format
('pve-roleid', \
&verify_rolename
);
533 sub verify_rolename
{
534 my ($rolename, $noerr) = @_;
536 if ($rolename !~ m/^[A-Za-z0-9\.\-_]+$/) {
538 die "role name '$rolename' contains invalid characters\n" if !$noerr;
546 PVE
::JSONSchema
::register_format
('pve-poolid', \
&verify_groupname
);
547 sub verify_poolname
{
548 my ($poolname, $noerr) = @_;
550 if ($poolname !~ m/^[A-Za-z0-9\.\-_]+$/) {
552 die "pool name '$poolname' contains invalid characters\n" if !$noerr;
560 PVE
::JSONSchema
::register_format
('pve-priv', \
&verify_privname
);
561 sub verify_privname
{
562 my ($priv, $noerr) = @_;
564 if (!$valid_privs->{$priv}) {
565 die "invalid priviledge '$priv'\n" if !$noerr;
573 sub userconfig_force_defaults
{
576 foreach my $r (keys %$special_roles) {
577 $cfg->{roles
}->{$r} = $special_roles->{$r};
580 # fixme: remove 'root' group (not required)?
583 $cfg->{users
}->{'root@pam'}->{enable
} = 1;
586 sub parse_user_config
{
587 my ($filename, $raw) = @_;
591 userconfig_force_defaults
($cfg);
593 while ($raw && $raw =~ s/^(.*?)(\n|$)//) {
596 next if $line =~ m/^\s*$/; # skip empty lines
600 foreach my $d (split (/:/, $line)) {
606 my $et = shift @data;
609 my ($user, $enable, $expire, $firstname, $lastname, $email, $comment) = @data;
611 my (undef, undef, $realm) = PVE
::Auth
::Plugin
::verify_username
($user, 1);
613 warn "user config - ignore user '$user' - invalid user name\n";
617 $enable = $enable ?
1 : 0;
619 $expire = 0 if !$expire;
621 if ($expire !~ m/^\d+$/) {
622 warn "user config - ignore user '$user' - (illegal characters in expire '$expire')\n";
625 $expire = int($expire);
627 #if (!verify_groupname ($group, 1)) {
628 # warn "user config - ignore user '$user' - invalid characters in group name\n";
632 $cfg->{users
}->{$user} = {
636 $cfg->{users
}->{$user}->{firstname
} = PVE
::Tools
::decode_text
($firstname) if $firstname;
637 $cfg->{users
}->{$user}->{lastname
} = PVE
::Tools
::decode_text
($lastname) if $lastname;
638 $cfg->{users
}->{$user}->{email
} = $email;
639 $cfg->{users
}->{$user}->{comment
} = PVE
::Tools
::decode_text
($comment) if $comment;
640 $cfg->{users
}->{$user}->{expire
} = $expire;
642 #$cfg->{users}->{$user}->{groups}->{$group} = 1;
643 #$cfg->{groups}->{$group}->{$user} = 1;
645 } elsif ($et eq 'group') {
646 my ($group, $userlist, $comment) = @data;
648 if (!verify_groupname
($group, 1)) {
649 warn "user config - ignore group '$group' - invalid characters in group name\n";
653 # make sure to add the group (even if there are no members)
654 $cfg->{groups
}->{$group} = { users
=> {} } if !$cfg->{groups
}->{$group};
656 $cfg->{groups
}->{$group}->{comment
} = PVE
::Tools
::decode_text
($comment) if $comment;
658 foreach my $user (split_list
($userlist)) {
660 if (!PVE
::Auth
::Plugin
::verify_username
($user, 1)) {
661 warn "user config - ignore invalid group member '$user'\n";
665 if ($cfg->{users
}->{$user}) { # user exists
666 $cfg->{users
}->{$user}->{groups
}->{$group} = 1;
667 $cfg->{groups
}->{$group}->{users
}->{$user} = 1;
669 warn "user config - ignore invalid group member '$user'\n";
673 } elsif ($et eq 'role') {
674 my ($role, $privlist) = @data;
676 if (!verify_rolename
($role, 1)) {
677 warn "user config - ignore role '$role' - invalid characters in role name\n";
681 # make sure to add the role (even if there are no privileges)
682 $cfg->{roles
}->{$role} = {} if !$cfg->{roles
}->{$role};
684 foreach my $priv (split_list
($privlist)) {
685 if (defined ($valid_privs->{$priv})) {
686 $cfg->{roles
}->{$role}->{$priv} = 1;
688 warn "user config - ignore invalid priviledge '$priv'\n";
692 } elsif ($et eq 'acl') {
693 my ($propagate, $pathtxt, $uglist, $rolelist) = @data;
695 if (my $path = normalize_path
($pathtxt)) {
696 foreach my $role (split_list
($rolelist)) {
698 if (!verify_rolename
($role, 1)) {
699 warn "user config - ignore invalid role name '$role' in acl\n";
703 foreach my $ug (split_list
($uglist)) {
704 if ($ug =~ m/^@(\S+)$/) {
706 if ($cfg->{groups
}->{$group}) { # group exists
707 $cfg->{acl
}->{$path}->{groups
}->{$group}->{$role} = $propagate;
709 warn "user config - ignore invalid acl group '$group'\n";
711 } elsif (PVE
::Auth
::Plugin
::verify_username
($ug, 1)) {
712 if ($cfg->{users
}->{$ug}) { # user exists
713 $cfg->{acl
}->{$path}->{users
}->{$ug}->{$role} = $propagate;
715 warn "user config - ignore invalid acl member '$ug'\n";
718 warn "user config - invalid user/group '$ug' in acl\n";
723 warn "user config - ignore invalid path in acl '$pathtxt'\n";
725 } elsif ($et eq 'pool') {
726 my ($pool, $comment, $vmlist, $storelist) = @data;
728 if (!verify_poolname
($pool, 1)) {
729 warn "user config - ignore pool '$pool' - invalid characters in pool name\n";
733 # make sure to add the pool (even if there are no members)
734 $cfg->{pools
}->{$pool} = { vms
=> {}, storage
=> {} } if !$cfg->{pools
}->{$pool};
736 $cfg->{pools
}->{$pool}->{comment
} = PVE
::Tools
::decode_text
($comment) if $comment;
738 foreach my $vmid (split_list
($vmlist)) {
739 if ($vmid !~ m/^\d+$/) {
740 warn "user config - ignore invalid vmid '$vmid' in pool '$pool'\n";
745 if ($cfg->{vms
}->{$vmid}) {
746 warn "user config - ignore duplicate vmid '$vmid' in pool '$pool'\n";
750 $cfg->{pools
}->{$pool}->{vms
}->{$vmid} = 1;
752 # record vmid ==> pool relation
753 $cfg->{vms
}->{$vmid} = $pool;
756 foreach my $storeid (split_list
($storelist)) {
757 if ($storeid !~ m/^[a-z][a-z0-9\-\_\.]*[a-z0-9]$/i) {
758 warn "user config - ignore invalid storage '$storeid' in pool '$pool'\n";
761 $cfg->{pools
}->{$pool}->{storage
}->{$storeid} = 1;
764 warn "user config - ignore config line: $line\n";
768 userconfig_force_defaults
($cfg);
773 sub write_user_config
{
774 my ($filename, $cfg) = @_;
778 foreach my $user (keys %{$cfg->{users
}}) {
779 my $d = $cfg->{users
}->{$user};
780 my $firstname = $d->{firstname
} ? PVE
::Tools
::encode_text
($d->{firstname
}) : '';
781 my $lastname = $d->{lastname
} ? PVE
::Tools
::encode_text
($d->{lastname
}) : '';
782 my $email = $d->{email
} || '';
783 my $comment = $d->{comment
} ? PVE
::Tools
::encode_text
($d->{comment
}) : '';
784 my $expire = int($d->{expire
} || 0);
785 my $enable = $d->{enable
} ?
1 : 0;
786 $data .= "user:$user:$enable:$expire:$firstname:$lastname:$email:$comment:\n";
791 foreach my $group (keys %{$cfg->{groups
}}) {
792 my $d = $cfg->{groups
}->{$group};
793 my $list = join (',', keys %{$d->{users
}});
794 my $comment = $d->{comment
} ? PVE
::Tools
::encode_text
($d->{comment
}) : '';
795 $data .= "group:$group:$list:$comment:\n";
800 foreach my $pool (keys %{$cfg->{pools
}}) {
801 my $d = $cfg->{pools
}->{$pool};
802 my $vmlist = join (',', keys %{$d->{vms
}});
803 my $storelist = join (',', keys %{$d->{storage
}});
804 my $comment = $d->{comment
} ? PVE
::Tools
::encode_text
($d->{comment
}) : '';
805 $data .= "pool:$pool:$comment:$vmlist:$storelist:\n";
810 foreach my $role (keys %{$cfg->{roles
}}) {
811 next if $special_roles->{$role};
813 my $d = $cfg->{roles
}->{$role};
814 my $list = join (',', keys %$d);
815 $data .= "role:$role:$list:\n";
820 foreach my $path (sort keys %{$cfg->{acl
}}) {
821 my $d = $cfg->{acl
}->{$path};
825 foreach my $group (keys %{$d->{groups
}}) {
828 foreach my $role (sort keys %{$d->{groups
}->{$group}}) {
829 my $propagate = $d->{groups
}->{$group}->{$role};
838 $ra->{0}->{$l0}->{"\@$group"} = 1 if $l0;
839 $ra->{1}->{$l1}->{"\@$group"} = 1 if $l1;
842 foreach my $user (keys %{$d->{users
}}) {
843 # no need to save, because root is always 'Administartor'
844 next if $user eq 'root@pam';
848 foreach my $role (sort keys %{$d->{users
}->{$user}}) {
849 my $propagate = $d->{users
}->{$user}->{$role};
858 $ra->{0}->{$l0}->{$user} = 1 if $l0;
859 $ra->{1}->{$l1}->{$user} = 1 if $l1;
862 foreach my $rolelist (sort keys %{$ra->{0}}) {
863 my $uglist = join (',', keys %{$ra->{0}->{$rolelist}});
864 $data .= "acl:0:$path:$uglist:$rolelist:\n";
866 foreach my $rolelist (sort keys %{$ra->{1}}) {
867 my $uglist = join (',', keys %{$ra->{1}->{$rolelist}});
868 $data .= "acl:1:$path:$uglist:$rolelist:\n";
876 my ($cfg, $user, $path) = @_;
878 # NOTE: we do not consider pools here.
879 # You need to use $rpcenv->roles() instead if you want that.
881 return 'Administrator' if $user eq 'root@pam'; # root can do anything
885 foreach my $p (sort keys %{$cfg->{acl
}}) {
886 my $final = ($path eq $p);
888 next if !(($p eq '/') || $final || ($path =~ m
|^$p/|));
890 my $acl = $cfg->{acl
}->{$p};
892 #print "CHECKACL $path $p\n";
893 #print "ACL $path = " . Dumper ($acl);
895 if (my $ri = $acl->{users
}->{$user}) {
897 foreach my $role (keys %$ri) {
898 my $propagate = $ri->{$role};
899 if ($final || $propagate) {
900 #print "APPLY ROLE $p $user $role\n";
906 $perm = $new; # overwrite previous settings
907 next; # user privs always override group privs
912 foreach my $g (keys %{$acl->{groups
}}) {
913 next if !$cfg->{groups
}->{$g}->{users
}->{$user};
914 if (my $ri = $acl->{groups
}->{$g}) {
915 foreach my $role (keys %$ri) {
916 my $propagate = $ri->{$role};
917 if ($final || $propagate) {
918 #print "APPLY ROLE $p \@$g $role\n";
926 $perm = $new; # overwrite previous settings
931 return ('NoAccess') if defined ($perm->{NoAccess
});
932 #return () if defined ($perm->{NoAccess});
934 #print "permission $user $path = " . Dumper ($perm);
936 my @ra = keys %$perm;
938 #print "roles $user $path = " . join (',', @ra) . "\n";
944 my ($cfg, $user, $path) = @_;
946 $user = PVE
::Auth
::Plugin
::verify_username
($user, 1);
949 my @ra = roles
($cfg, $user, $path);
953 foreach my $role (@ra) {
954 if (my $privset = $cfg->{roles
}->{$role}) {
955 foreach my $p (keys %$privset) {
961 #print "priviledges $user $path = " . Dumper ($privs);
966 sub check_permissions
{
967 my ($username, $path, $privlist) = @_;
969 $path = normalize_path
($path);
970 my $usercfg = cfs_read_file
('user.cfg');
971 my $perm = permission
($usercfg, $username, $path);
973 foreach my $priv (split_list
($privlist)) {
974 return undef if !$perm->{$priv};
981 my ($vmid, $pool) = @_;
983 my $addVMtoPoolFn = sub {
984 my $usercfg = cfs_read_file
("user.cfg");
985 if (my $data = $usercfg->{pools
}->{$pool}) {
986 $data->{vms
}->{$vmid} = 1;
987 $usercfg->{vms
}->{$vmid} = $pool;
988 cfs_write_file
("user.cfg", $usercfg);
992 lock_user_config
($addVMtoPoolFn, "can't add VM $vmid to pool '$pool'");
995 sub remove_vm_from_pool
{
998 my $delVMfromPoolFn = sub {
999 my $usercfg = cfs_read_file
("user.cfg");
1000 if (my $pool = $usercfg->{vms
}->{$vmid}) {
1001 if (my $data = $usercfg->{pools
}->{$pool}) {
1002 delete $data->{vms
}->{$vmid};
1003 delete $usercfg->{vms
}->{$vmid};
1004 cfs_write_file
("user.cfg", $usercfg);
1009 lock_user_config
($delVMfromPoolFn, "pool cleanup for VM $vmid failed");