]>
git.proxmox.com Git - pve-access-control.git/blob - PVE/RPCEnvironment.pm
14e6849cc411ec43f14b557e0be728532a053a2f
1 package PVE
::RPCEnvironment
;
5 use POSIX
qw(:sys_wait_h EINTR);
10 use PVE
::Exception
qw(raise raise_perm_exc);
16 use PVE
::AccessControl
;
19 # we use this singleton class to pass RPC related environment values
23 # save $SIG{CHLD} handler implementation.
24 # simply set $SIG{CHLD} = $worker_reaper;
25 # and register forked processes with &$register_worker(pid)
26 # Note: using $SIG{CHLD} = 'IGNORE' or $SIG{CHLD} = sub { wait (); } or ...
27 # has serious side effects, because perls built in system() and open()
28 # functions can't get the correct exit status of a child. So we cant use
29 # that (also see perlipc)
33 my $log_task_result = sub {
34 my ($upid, $user, $status) = @_;
36 my $msg = 'successful';
39 my $ec = $status >> 8;
40 my $ic = $status & 255;
41 $msg = $ec ?
"failed ($ec)" : "interrupted ($ic)";
44 my $tlist = active_workers
($upid);
45 PVE
::Cluster
::broadcast_tasklist
($tlist);
47 foreach my $t (@$tlist) {
48 if ($t->{upid
} eq $upid) {
53 if ($task && $task->{status
}) {
54 $msg = $task->{status
};
56 PVE
::Cluster
::log_msg
($pri, $user, "end task $upid $msg");
59 my $worker_reaper = sub {
61 foreach my $pid (keys %$WORKER_PIDS) {
62 my $waitpid = waitpid ($pid, WNOHANG
);
63 if (defined($waitpid) && ($waitpid == $pid)) {
64 my $info = $WORKER_PIDS->{$pid};
65 if ($info && $info->{upid
} && $info->{user
}) {
66 &$log_task_result($info->{upid
}, $info->{user
}, $?);
68 delete ($WORKER_PIDS->{$pid});
73 my $register_worker = sub {
74 my ($pid, $user, $upid) = @_;
78 # do not register if already finished
79 my $waitpid = waitpid ($pid, WNOHANG
);
80 if (defined($waitpid) && ($waitpid == $pid)) {
81 delete ($WORKER_PIDS->{$pid});
85 $WORKER_PIDS->{$pid} = {
93 my $compile_acl_path = sub {
94 my ($self, $user, $path) = @_;
96 my $cfg = $self->{user_cfg
};
98 return undef if !$cfg->{roles
};
100 die "internal error" if $user eq 'root@pam';
102 my $cache = $self->{aclcache
};
103 $cache->{$user} = {} if !$cache->{$user};
104 my $data = $cache->{$user};
106 if (!$data->{poolroles
}) {
107 $data->{poolroles
} = {};
109 foreach my $pool (keys %{$cfg->{pools
}}) {
110 my $d = $cfg->{pools
}->{$pool};
111 my @ra = PVE
::AccessControl
::roles
($cfg, $user, "/pool/$pool"); # pool roles
112 next if !scalar(@ra);
113 foreach my $vmid (keys %{$d->{vms
}}) {
115 $data->{poolroles
}->{"/vms/$vmid"}->{$role} = 1;
118 foreach my $storeid (keys %{$d->{storage
}}) {
120 $data->{poolroles
}->{"/storage/$storeid"}->{$role} = 1;
126 my @ra = PVE
::AccessControl
::roles
($cfg, $user, $path);
128 # apply roles inherited from pools
129 # Note: assume we do not want to propagate those privs
130 if ($data->{poolroles
}->{$path}) {
131 if (!($ra[0] && $ra[0] eq 'NoAccess')) {
132 if ($data->{poolroles
}->{$path}->{NoAccess
}) {
135 foreach my $role (keys %{$data->{poolroles
}->{$path}}) {
142 $data->{roles
}->{$path} = [ @ra ];
145 foreach my $role (@ra) {
146 if (my $privset = $cfg->{roles
}->{$role}) {
147 foreach my $p (keys %$privset) {
152 $data->{privs
}->{$path} = $privs;
158 my ($self, $user, $path) = @_;
160 if ($user eq 'root@pam') { # root can do anything
161 return ('Administrator');
164 $user = PVE
::AccessControl
::verify_username
($user, 1);
167 my $cache = $self->{aclcache
};
168 $cache->{$user} = {} if !$cache->{$user};
170 my $acl = $cache->{$user};
172 my $roles = $acl->{roles
}->{$path};
173 return @$roles if $roles;
175 &$compile_acl_path($self, $user, $path);
176 $roles = $acl->{roles
}->{$path} || [];
181 my ($self, $user, $path) = @_;
183 if ($user eq 'root@pam') { # root can do anything
184 my $cfg = $self->{user_cfg
};
185 return $cfg->{roles
}->{'Administrator'};
188 $user = PVE
::AccessControl
::verify_username
($user, 1);
191 my $cache = $self->{aclcache
};
192 $cache->{$user} = {} if !$cache->{$user};
194 my $acl = $cache->{$user};
196 my $perm = $acl->{privs
}->{$path};
197 return $perm if $perm;
199 return &$compile_acl_path($self, $user, $path);
203 my ($self, $user, $path, $privs, $noerr) = @_;
205 my $perm = $self->permissions($user, $path);
207 foreach my $priv (@$privs) {
208 PVE
::AccessControl
::verify_privname
($priv);
209 if (!$perm->{$priv}) {
210 return undef if $noerr;
211 raise_perm_exc
("$path, $priv");
219 my ($self, $user, $path, $privs, $noerr) = @_;
221 my $perm = $self->permissions($user, $path);
224 foreach my $priv (@$privs) {
225 PVE
::AccessControl
::verify_privname
($priv);
226 if ($perm->{$priv}) {
234 return undef if $noerr;
236 raise_perm_exc
("$path, " . join("|", @$privs));
240 my ($self, $username, $path, $privs, $any, $noerr) = @_;
242 return $self->check_any($username, $path, $privs, $noerr);
244 return $self->check($username, $path, $privs, $noerr);
248 sub check_user_enabled
{
249 my ($self, $user, $noerr) = @_;
251 my $cfg = $self->{user_cfg
};
252 return PVE
::AccessControl
::check_user_enabled
($cfg, $user, $noerr);
255 sub check_user_exist
{
256 my ($self, $user, $noerr) = @_;
258 my $cfg = $self->{user_cfg
};
259 return PVE
::AccessControl
::check_user_exist
($cfg, $user, $noerr);
262 sub check_pool_exist
{
263 my ($self, $pool, $noerr) = @_;
265 my $cfg = $self->{user_cfg
};
267 return 1 if $cfg->{pools
}->{$pool};
269 return undef if $noerr;
271 raise_perm_exc
("pool '$pool' does not exist");
275 my ($self, $user, $vmid, $pool, $privs, $any, $noerr) = @_;
277 my $cfg = $self->{user_cfg
};
280 return if $self->check_full($user, "/pool/$pool", $privs, $any, 1);
282 return $self->check_full($user, "/vms/$vmid", $privs, $any, $noerr);
285 sub is_group_member
{
286 my ($self, $group, $user) = @_;
288 my $cfg = $self->{user_cfg
};
290 return 0 if !$cfg->{groups
}->{$group};
292 return defined($cfg->{groups
}->{$group}->{users
}->{$user});
296 my ($self, $user, $privs, $any) = @_;
298 my $cfg = $self->{user_cfg
};
301 foreach my $group (keys %{$cfg->{groups
}}) {
302 my $path = "/access/groups/$group";
303 if ($self->check_full($user, $path, $privs, $any, 1)) {
304 $groups->{$group} = $cfg->{groups
}->{$group};
311 sub group_member_join
{
312 my ($self, $grouplist) = @_;
316 my $cfg = $self->{user_cfg
};
317 foreach my $group (@$grouplist) {
318 my $data = $cfg->{groups
}->{$group};
320 foreach my $user (keys %{$data->{users
}}) {
328 sub check_perm_modify
{
329 my ($self, $username, $path, $noerr) = @_;
331 return $self->check($username, '/access', [ 'Permissions.Modify' ], $noerr) if !$path;
333 my $testperms = [ 'Permissions.Modify' ];
334 if ($path =~ m
|^/storage/.+$|) {
335 push @$testperms, 'Datastore.Allocate';
336 } elsif ($path =~ m
|^/vms/.+$|) {
337 push @$testperms, 'VM.Allocate';
338 } elsif ($path =~ m
|^/pool/.+$|) {
339 push @$testperms, 'Pool.Allocate';
342 return $self->check_any($username, $path, $testperms, $noerr);
345 sub exec_api2_perm_check
{
346 my ($self, $check, $username, $param, $noerr) = @_;
348 # syslog("info", "CHECK " . join(', ', @$check));
351 my $test = $check->[$ind++];
352 die "no permission test specified" if !$test;
354 if ($test eq 'and') {
355 while (my $subcheck = $check->[$ind++]) {
356 $self->exec_api2_perm_check($subcheck, $username, $param);
359 } elsif ($test eq 'or') {
360 while (my $subcheck = $check->[$ind++]) {
361 return 1 if $self->exec_api2_perm_check($subcheck, $username, $param, 1);
365 } elsif ($test eq 'perm') {
366 my ($t, $tmplpath, $privs, %options) = @$check;
367 my $any = $options{any
};
368 die "missing parameters" if !($tmplpath && $privs);
369 my $require_param = $options{require_param
};
370 if ($require_param && !defined($param->{$require_param})) {
374 my $path = PVE
::Tools
::template_replace
($tmplpath, $param);
375 $path = PVE
::AccessControl
::normalize_path
($path);
376 return $self->check_full($username, $path, $privs, $any, $noerr);
377 } elsif ($test eq 'userid-group') {
378 my $userid = $param->{userid
};
379 my ($t, $privs, %options) = @$check;
380 return 0 if !$options{groups_param
} && !$self->check_user_exist($userid, $noerr);
381 if (!$self->check_any($username, "/access/groups", $privs, 1)) {
382 my $groups = $self->filter_groups($username, $privs, 1);
383 if ($options{groups_param
}) {
384 my @group_param = PVE
::Tools
::split_list
($param->{groups
});
385 raise_perm_exc
("/access/groups, " . join("|", @$privs)) if !scalar(@group_param);
386 foreach my $pg (@group_param) {
387 raise_perm_exc
("/access/groups/$pg, " . join("|", @$privs))
391 my $allowed_users = $self->group_member_join([keys %$groups]);
392 if (!$allowed_users->{$userid}) {
399 } elsif ($test eq 'userid-param') {
400 my ($userid, undef, $realm) = verify_username
($param->{userid
});
401 return if !$self->check_user_exist($userid, $noerr);
402 my ($t, $subtest) = @$check;
403 die "missing parameters" if !$subtest;
404 if ($subtest eq 'self') {
405 return 1 if $username eq 'userid';
408 } elsif ($subtest eq 'Realm.AllocateUser') {
409 my $path = "/access/realm/$realm";
410 return $self->check($username, $path, ['Realm.AllocateUser'], $noerr);
412 die "unknown userid-param test";
414 } elsif ($test eq 'perm-modify') {
415 my ($t, $tmplpath) = @$check;
416 my $path = PVE
::Tools
::template_replace
($tmplpath, $param);
417 $path = PVE
::AccessControl
::normalize_path
($path);
418 return $self->check_perm_modify($username, $path, $noerr);
420 die "unknown permission test";
424 sub check_api2_permissions
{
425 my ($self, $perm, $username, $param) = @_;
427 return 1 if !$username && $perm->{user
} eq 'world';
429 raise_perm_exc
("user != null") if !$username;
431 return 1 if $username eq 'root@pam';
433 raise_perm_exc
('user != root@pam') if !$perm;
435 return 1 if $perm->{user
} && $perm->{user
} eq 'all';
437 return $self->exec_api2_perm_check($perm->{check
}, $username, $param)
443 # initialize environment - must be called once at program startup
445 my ($class, $type, %params) = @_;
447 $class = ref($class) || $class;
449 die "already initialized" if $pve_env;
451 die "unknown environment type" if !$type || $type !~ m/^(cli|pub|priv|ha)$/;
453 $SIG{CHLD
} = $worker_reaper;
456 # cli ... command started fron command line
457 # pub ... access from public server (apache)
458 # priv ... access from private server (pvedaemon)
459 # ha ... access from HA resource manager agent (rgmanager)
470 foreach my $p (keys %params) {
471 if ($p eq 'atfork') {
472 $self->{$p} = $params{$p};
474 die "unknown option '$p'";
480 my ($sysname, $nodename) = POSIX
::uname
();
482 $nodename =~ s/\..*$//; # strip domain part, if any
484 $self->{nodename
} = $nodename;
492 die "not initialized" if !$pve_env;
498 my ($self, $enable_upload) = @_;
500 if ($self->{request_rec
}) {
502 if ($enable_upload) {
503 $cgi = CGI-
>new($self->{request_rec
});
505 # disable upload using empty upload_hook
506 $cgi = CGI-
>new($self->{request_rec
}, sub {}, undef, 0);
509 my $params = $cgi->Vars();
510 return PVE
::Tools
::decode_utf8_parameters
($params);
511 } elsif ($self->{params
}) {
512 return $self->{params
};
514 die "no parameters registered";
518 sub get_upload_info
{
519 my ($self, $param) = @_;
521 my $cgi = $self->{cgi
};
522 die "CGI not initialized" if !$cgi;
524 my $pd = $cgi->param($param);
525 die "unable to get cgi parameter info\n" if !$pd;
526 my $info = $cgi->uploadInfo($pd);
527 die "unable to get cgi upload info\n" if !$info;
529 my $res = { %$info };
531 my $tmpfilename = $cgi->tmpFileName($pd);
532 die "unable to get cgi upload file name\n" if !$tmpfilename;
533 $res->{tmpfilename
} = $tmpfilename;
535 #my $hndl = $cgi->upload($param);
536 #die "unable to get cgi upload handle\n" if !$hndl;
537 #$res->{handle} = $hndl->handle;
542 # init_request - must be called before each RPC request
544 my ($self, %params) = @_;
546 PVE
::Cluster
::cfs_update
();
548 $self->{result_attributes
} = {};
550 my $userconfig; # we use this for regression tests
551 foreach my $p (keys %params) {
552 if ($p eq 'userconfig') {
553 $userconfig = $params{$p};
554 } elsif ($p eq 'request_rec') {
555 # pass Apache2::RequestRec
556 $self->{request_rec
} = $params{$p};
557 } elsif ($p eq 'params') {
558 $self->{params
} = $params{$p};
560 die "unknown parameter '$p'";
565 $self->{aclcache
} = {};
567 my $ucdata = PVE
::Tools
::file_get_contents
($userconfig);
568 my $cfg = PVE
::AccessControl
::parse_user_config
($userconfig, $ucdata);
569 $self->{user_cfg
} = $cfg;
572 my $ucvers = PVE
::Cluster
::cfs_file_version
('user.cfg');
573 if (!$self->{aclcache
} || !defined($self->{aclversion
}) ||
574 !defined($ucvers) || ($ucvers ne $self->{aclversion
})) {
575 $self->{aclversion
} = $ucvers;
576 my $cfg = PVE
::Cluster
::cfs_read_file
('user.cfg');
577 $self->{user_cfg
} = $cfg;
582 $self->{user_cfg
} = {};
583 die "Unable to load access control list: $err";
588 my ($self, $ip) = @_;
590 $self->{client_ip
} = $ip;
596 return $self->{client_ip
};
599 sub set_result_attrib
{
600 my ($self, $key, $value) = @_;
602 $self->{result_attributes
}->{$key} = $value;
605 sub get_result_attrib
{
606 my ($self, $key) = @_;
608 return $self->{result_attributes
}->{$key};
612 my ($self, $lang) = @_;
614 # fixme: initialize I18N
616 $self->{language
} = $lang;
622 return $self->{language
};
626 my ($self, $user) = @_;
630 $self->{user
} = $user;
636 die "user name not set\n" if !$self->{user
};
638 return $self->{user
};
641 # read/update list of active workers
642 # we move all finished tasks to the archive index,
643 # but keep aktive and most recent task in the active file.
644 # $nocheck ... consider $new_upid still running (avoid that
645 # we try to read the reult to early.
647 my ($new_upid, $nocheck) = @_;
649 my $lkfn = "/var/log/pve/tasks/.active.lock";
655 my $tasklist = PVE
::INotify
::read_file
('active');
659 my $thash = {}; # only list task once
661 my $check_task = sub {
662 my ($task, $running) = @_;
664 if ($running || PVE
::ProcFSTools
::check_process_running
($task->{pid
}, $task->{pstart
})) {
670 delete $task->{pstart
};
673 foreach my $task (@$tasklist) {
674 my $upid = $task->{upid
};
675 next if $thash->{$upid};
676 $thash->{$upid} = $task;
680 if ($new_upid && !(my $task = $thash->{$new_upid})) {
681 $task = PVE
::Tools
::upid_decode
($new_upid);
682 $task->{upid
} = $new_upid;
683 $thash->{$new_upid} = $task;
684 &$check_task($task, $nocheck);
688 @ta = sort { $b->{starttime
} cmp $a->{starttime
} } @ta;
690 my $save = defined($new_upid);
692 foreach my $task (@ta) {
693 next if $task->{endtime
};
694 $task->{endtime
} = time();
695 $task->{status
} = PVE
::Tools
::upid_read_status
($task->{upid
});
701 foreach my $task (@ta) {
702 if (!$task->{saved
}) {
703 $archive .= sprintf("$task->{upid} %08X $task->{status}\n", $task->{endtime
});
712 my $filename = "/var/log/pve/tasks/index";
714 my $fh = IO
::File-
>new($filename, '>>', 0644) ||
715 die "unable to open file '$filename' - $!\n";
716 PVE
::Tools
::safe_print
($filename, $fh, $archive);
719 die "unable to close file '$filename' - $!\n";
724 foreach my $task (@arlist) { # mark as not saved
728 my $maxsize = 50000; # about 1000 entries
729 if ($size > $maxsize) {
730 rename($filename, "$filename.1");
734 # we try to reduce the amount of data
735 # list all running tasks and task and a few others
736 # try to limit to 25 tasks
738 my $max = 25 - scalar(@$tlist);
739 foreach my $task (@ta) {
745 PVE
::INotify
::write_file
('active', $tlist) if $save;
750 my $res = PVE
::Tools
::lock_file
($lkfn, $timeout, $code);
756 my $kill_process_group = sub {
757 my ($pid, $pstart) = @_;
759 # send kill to process group (negative pid)
762 # always send signal to all pgrp members
763 kill(15, $kpid); # send TERM signal
765 # give max 5 seconds to shut down
766 for (my $i = 0; $i < 5; $i++) {
767 return if !PVE
::ProcFSTools
::check_process_running
($pid, $pstart);
776 my ($upid, $killit) = @_;
778 my $task = PVE
::Tools
::upid_decode
($upid);
780 my $running = PVE
::ProcFSTools
::check_process_running
($task->{pid
}, $task->{pstart
});
782 return 0 if !$running;
785 &$kill_process_group($task->{pid
});
792 # start long running workers
793 # STDIN is redirected to /dev/null
794 # STDOUT,STDERR are redirected to the filename returned by upid_decode
795 # NOTE: we simulate running in foreground if ($self->{type} eq 'cli')
797 my ($self, $dtype, $id, $user, $function) = @_;
799 $dtype = 'unknown' if !defined ($dtype);
800 $id = '' if !defined ($id);
802 $user = 'root@pve' if !defined ($user);
804 my $sync = $self->{type
} eq 'cli' ?
1 : 0;
809 local $SIG{TERM
} = 'IGNORE';
811 my $starttime = time ();
813 my @psync = POSIX
::pipe();
814 my @csync = POSIX
::pipe();
816 my $node = $self->{nodename
};
819 die "unable to fork worker - $!" if !defined($cpid);
821 my $workerpuid = $cpid ?
$cpid : $$;
823 my $pstart = PVE
::ProcFSTools
::read_proc_starttime
($workerpuid) ||
824 die "unable to read process start time";
826 my $upid = PVE
::Tools
::upid_encode
({
827 node
=> $node, pid
=> $workerpuid, pstart
=> $pstart,
828 starttime
=> $starttime, type
=> $dtype, id
=> $id, user
=> $user });
832 if (!$cpid) { # child
836 $SIG{INT
} = $SIG{QUIT
} = $SIG{TERM
} = sub { die "received interrupt\n"; };
838 $SIG{CHLD
} = $SIG{PIPE
} = 'DEFAULT';
840 # set sess/process group - we want to be able to kill the
841 # whole process group
844 POSIX
::close ($psync[0]);
845 POSIX
::close ($csync[1]);
847 $outfh = $sync ?
$psync[1] : undef;
850 PVE
::INotify
::inotify_close
();
852 if (my $atfork = $self->{atfork
}) {
856 # same algorythm as used inside SA
858 my $fd = fileno (STDIN
);
862 POSIX
::close(0) if $fd != 0;
864 die "unable to redirect STDIN - $!"
865 if !open(STDIN
, "</dev/null");
867 $outfh = PVE
::Tools
::upid_open
($upid);
872 $fd = fileno(STDOUT
);
874 POSIX
::close (1) if $fd != 1;
876 die "unable to redirect STDOUT - $!"
877 if !open(STDOUT
, ">&", $outfh);
879 STDOUT-
>autoflush (1);
881 # redirect STDERR to STDOUT
882 $fd = fileno (STDERR
);
884 POSIX
::close(2) if $fd != 2;
886 die "unable to redirect STDERR - $!"
887 if !open(STDERR
, ">&1");
889 STDERR-
>autoflush(1);
892 my $msg = "ERROR: $err";
893 POSIX
::write($psync[1], $msg, length ($msg));
894 POSIX
::close($psync[1]);
899 # sync with parent (signal that we are ready)
903 POSIX
::write($psync[1], $upid, length ($upid));
904 POSIX
::close($psync[1]);
908 # sync with parent (wait until parent is ready)
909 POSIX
::read($csync[0], $readbuf, 4096);
910 die "parent setup error\n" if $readbuf ne 'OK';
912 if ($self->{type
} eq 'ha') {
913 print "task started by HA resource agent\n";
915 eval { &$function($upid); };
921 print STDERR
"TASK ERROR: $err\n";
924 print STDERR
"TASK OK\n";
932 POSIX
::close ($psync[1]);
933 POSIX
::close ($csync[0]);
936 # sync with child (wait until child starts)
937 POSIX
::read($psync[0], $readbuf, 4096);
940 POSIX
::close($psync[0]);
941 &$register_worker($cpid, $user, $upid);
947 die "got no worker upid - start worker failed\n" if !$readbuf;
949 if ($readbuf =~ m/^ERROR:\s*(.+)$/m) {
950 die "starting worker failed: $1\n";
953 if ($readbuf ne $upid) {
954 die "got strange worker upid ('$readbuf' != '$upid') - start worker failed\n";
958 $outfh = PVE
::Tools
::upid_open
($upid);
965 POSIX
::write($csync[1], $msg, length ($msg));
966 POSIX
::close($csync[1]);
969 POSIX
::close($csync[1]);
970 kill(-9, $cpid); # make sure it gets killed
974 PVE
::Cluster
::log_msg
('info', $user, "starting task $upid");
976 my $tlist = active_workers
($upid, $sync);
977 PVE
::Cluster
::broadcast_tasklist
($tlist);
986 local $SIG{INT
} = local $SIG{QUIT
} = local $SIG{TERM
} = sub {
987 # always send signal to all pgrp members
989 if ($int_count < 3) {
990 kill(15, $kpid); # send TERM signal
992 kill(9, $kpid); # send KILL signal
996 local $SIG{PIPE
} = sub { die "broken pipe\n"; };
998 my $select = new IO
::Select
;
999 my $fh = IO
::Handle-
>new_from_fd($psync[0], 'r');
1002 while ($select->count) {
1003 my @handles = $select->can_read(1);
1004 if (scalar(@handles)) {
1005 my $count = sysread ($handles[0], $readbuf, 4096);
1006 if (!defined ($count)) {
1008 die "sync pipe read error: $err\n";
1010 last if $count == 0; # eof
1012 $outbuf .= $readbuf;
1013 while ($outbuf =~ s/^(([^\010\r\n]*)(\r|\n|(\010)+|\r\n))//s) {
1016 if ($data =~ m/^TASK OK$/) {
1018 } elsif ($data =~ m/^TASK ERROR: (.+)$/) {
1019 print STDERR
"$1\n";
1029 # some commands daemonize without closing stdout
1030 last if !PVE
::ProcFSTools
::check_process_running
($cpid);
1036 POSIX
::close($psync[0]);
1038 if ($outbuf) { # just to be sure
1041 print $outfh $outbuf;
1047 print STDERR
"$err\n";
1049 print $outfh "TASK ERROR: $err\n";
1053 &$kill_process_group($cpid, $pstart); # make sure it gets killed
1059 &$log_task_result($upid, $user, $res);
1062 return wantarray ?
($upid, $res) : $upid;