]> git.proxmox.com Git - pve-cluster.git/commitdiff
pmxcfs sync: properly check for corosync error
authorFabian Grünbichler <f.gruenbichler@proxmox.com>
Fri, 25 Sep 2020 12:53:49 +0000 (14:53 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 25 Sep 2020 13:16:41 +0000 (15:16 +0200)
dfsm_send_state_message_full always returns != 0, since it returns
cs_error_t which starts with CS_OK at 1, with values >1 representing
errors.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
data/src/dfsm.c

index 529c7f99792a59decbb9125d86528950895e38cb..172d8772024c0000ec7a71b2e049e833d9e7b1f4 100644 (file)
@@ -1190,7 +1190,7 @@ dfsm_cpg_confchg_callback(
 
                dfsm_set_mode(dfsm, DFSM_MODE_START_SYNC);
                if (lowest_nodeid == dfsm->nodeid) {
-                       if (!dfsm_send_state_message_full(dfsm, DFSM_MESSAGE_SYNC_START, NULL, 0)) {
+                       if (dfsm_send_state_message_full(dfsm, DFSM_MESSAGE_SYNC_START, NULL, 0) != CS_OK) {
                                cfs_dom_critical(dfsm->log_domain, "failed to send SYNC_START message");
                                goto leave;
                        }