pmxcfs: db: use SQLITE_STATIC to avoid memory copies

we can trust that we own *value and *name until the sqlite statement
was executed, so use the STATIC bind flag to tell sqlite that it does
not need to make it's own copy in the bind statement.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/data/src/database.c b/data/src/database.c
index bf6dc5dff8bdfb76b326940879238e75f9ed32ac..e3949ef26b392f08dcb0e1ad17dc078c32c31b90 100644 (file)
--- a/data/src/database.c
+++ b/data/src/database.c
@@ -185,12 +185,11 @@ static int backend_write_inode(
                cfs_critical("sqlite3_bind failed: %s\n", sqlite3_errmsg(db));
                return rc;
        }
-       /* question: can we use SQLITE_STATIC instead? */
-       if ((rc = sqlite3_bind_text(stmt, 7, name, -1, SQLITE_TRANSIENT)) !=  SQLITE_OK) {
+       if ((rc = sqlite3_bind_text(stmt, 7, name, -1, SQLITE_STATIC)) !=  SQLITE_OK) {
                cfs_critical("sqlite3_bind failed: %s\n", sqlite3_errmsg(db));
                return rc;
        }
-       if ((rc = sqlite3_bind_blob(stmt, 8, value, size, SQLITE_TRANSIENT)) !=  SQLITE_OK) {
+       if ((rc = sqlite3_bind_blob(stmt, 8, value, size, SQLITE_STATIC)) !=  SQLITE_OK) {
                cfs_critical("sqlite3_bind failed: %s\n", sqlite3_errmsg(db));
                return rc;
        }