]> git.proxmox.com Git - pve-guest-common.git/commitdiff
migrate: handle migration_network with remote migration
authorFabian Grünbichler <f.gruenbichler@proxmox.com>
Thu, 3 Feb 2022 12:41:22 +0000 (13:41 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Fri, 4 Feb 2022 16:36:44 +0000 (17:36 +0100)
remote migration always has an explicit endpoint from the start which
gets used for everything.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
src/PVE/AbstractMigrate.pm

index af2be389901b1d5c643c0f0283b43be477347212..a20b213b4cbb70407e4589a2741abf9ea0bf8690 100644 (file)
@@ -115,22 +115,27 @@ sub migrate {
 
     $class = ref($class) || $class;
 
-    my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg');
+    my ($ssh_info, $rem_ssh);
+    if (!$opts->{remote}) {
+       my $dc_conf = PVE::Cluster::cfs_read_file('datacenter.cfg');
 
-    my $migration_network = $opts->{migration_network};
-    if (!defined($migration_network)) {
-       $migration_network = $dc_conf->{migration}->{network};
-    }
-    my $ssh_info = PVE::SSHInfo::get_ssh_info($node, $migration_network);
-    $nodeip = $ssh_info->{ip};
-
-    my $migration_type = 'secure';
-    if (defined($opts->{migration_type})) {
-       $migration_type = $opts->{migration_type};
-    } elsif (defined($dc_conf->{migration}->{type})) {
-        $migration_type = $dc_conf->{migration}->{type};
+       my $migration_network = $opts->{migration_network};
+       if (!defined($migration_network)) {
+           $migration_network = $dc_conf->{migration}->{network};
+       }
+       $ssh_info = PVE::SSHInfo::get_ssh_info($node, $migration_network);
+       $nodeip = $ssh_info->{ip};
+
+       my $migration_type = 'secure';
+       if (defined($opts->{migration_type})) {
+           $migration_type = $opts->{migration_type};
+       } elsif (defined($dc_conf->{migration}->{type})) {
+           $migration_type = $dc_conf->{migration}->{type};
+       }
+       $opts->{migration_type} = $migration_type;
+       $opts->{migration_network} = $migration_network;
+       $rem_ssh = PVE::SSHInfo::ssh_info_to_command($ssh_info);
     }
-    $opts->{migration_type} = $migration_type;
 
     my $self = {
        delayed_interrupt => 0,
@@ -139,7 +144,7 @@ sub migrate {
        node => $node,
        ssh_info => $ssh_info,
        nodeip => $nodeip,
-       rem_ssh => PVE::SSHInfo::ssh_info_to_command($ssh_info)
+       rem_ssh => $rem_ssh,
     };
 
     $self = bless $self, $class;
@@ -162,7 +167,7 @@ sub migrate {
        &$eval_int($self, sub { $self->{running} = $self->prepare($self->{vmid}); });
        die $@ if $@;
 
-       if (defined($migration_network)) {
+       if (defined($self->{opts}->{migration_network})) {
            $self->log('info', "use dedicated network address for sending " .
                       "migration traffic ($self->{nodeip})");