Especially unconfigured.sh is worth checking consistently.
Running shellcheck also does not really have any notable impact on build
time, so no downside there either.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
COMPILED_BINS := \
$(addprefix $(CARGO_COMPILEDIR)/,$(USR_BIN))
+SHELL_SCRIPTS := \
+ fake-start-stop-daemon \
+ policy-disable-rc.d \
+ spice-vdagent.sh \
+ unconfigured.sh \
+ xinitrc
+
all:
$(BUILDDIR):
banner/ \
checktime \
country.pl \
- fake-start-stop-daemon \
html/ \
interfaces \
- policy-disable-rc.d \
proxinstall \
proxmox-low-level-installer \
proxmox-tui-installer/ \
proxmox-installer-common/ \
- spice-vdagent.sh \
test/ \
- unconfigured.sh \
- xinitrc \
+ $(SHELL_SCRIPTS) \
$@.tmp
cp -a debian $@.tmp/
mv $@.tmp $@
.PHONY: test
test: prepare-test-env
+ shellcheck $(SHELL_SCRIPTS)
$(MAKE) -C test check
$(CARGO) test --workspace $(CARGO_BUILD_ARGS)
libtest-mockmodule-perl,
perl,
rustc:native,
+ shellcheck,
Standards-Version: 4.5.1
Homepage: https://www.proxmox.com
exit 0 # shouldn't be reached, kernel will panic in that case
}
+# reachable through the ERR trap
+# shellcheck disable=SC2317
err_reboot() {
printf "\nInstallation aborted - unable to continue (type exit or CTRL-D to reboot)\n"
debugsh || true
real_reboot
# never reached
+# shellcheck disable=SC2317
exit 0
+#!/bin/sh
+
/usr/bin/xrdb -load /.Xdefaults
/usr/bin/X11/xsetroot -solid grey
openbox &