proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm

Fletcher-2 has long been deprecated and should not be used anymore
[0][1], so we probably should not offer it anymore too. It's been
deprecated since at least over 3 years, beyond that it's hard to find
an exact date.

[0]: https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#checksum-algorithms
[1]: https://people.freebsd.org/~asomers/fletcher.pdf

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>

diff --git a/proxinstall b/proxinstall
index 01d4cfeb6b84f266a4f7b29d466ba179ce3f5393..d6d5acbad6b3d7b042beaa4c65c267c48afbfc66 100755 (executable)
--- a/proxinstall
+++ b/proxinstall
@@ -1145,7 +1145,7 @@ my $create_raid_advanced_grid = sub {
 
     my $combo_checksum = Gtk3::ComboBoxText->new();
     $combo_checksum->set_tooltip_text("zfs checksum algorithm for rpool dataset");
-    my $csum_opts = ["on", "off","fletcher2", "fletcher4", "sha256"];
+    my $csum_opts = ["on", "off", "fletcher4", "sha256"];
     foreach my $opt (@$csum_opts) {
        $combo_checksum->append($opt, $opt);
     }

diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs
index afd12cda0aee94c23f814ef25414fff8e0e513bc..98cd90719997a9790f83de2780c9d829aadd99ca 100644 (file)
--- a/proxmox-installer-common/src/options.rs
+++ b/proxmox-installer-common/src/options.rs
@@ -146,7 +146,6 @@ pub enum ZfsChecksumOption {
     #[default]
     On,
     Off,
-    Fletcher2,
     Fletcher4,
     Sha256,
 }
@@ -165,7 +164,7 @@ impl From<&ZfsChecksumOption> for String {
 
 pub const ZFS_CHECKSUM_OPTIONS: &[ZfsChecksumOption] = {
     use ZfsChecksumOption::*;
-    &[On, Off, Fletcher2, Fletcher4, Sha256]
+    &[On, Off, Fletcher4, Sha256]
 };
 
 #[derive(Clone, Debug)]