api network: make IPv6 address checking spew out useful errors

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 7919756c6af919401e6c7f890a5f0b9dd511d6bb..e58c71106a29c1d825809276b63aa6a635021fb5 100644 (file)
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@ -274,17 +274,17 @@ my $check_ipv6_settings = sub {
     raise_param_exc({ netmask => "$netmask is not a valid subnet length for ipv6" })
        if $netmask < 0 || $netmask > 128;
 
-    raise_param_exc({ address => "$address is not a valid host ip address." })
+    raise_param_exc({ address => "$address is not a valid host IPv6 address." })
        if !Net::IP::ip_is_ipv6($address);
 
     my $binip = ipv6_tobin($address);
     my $binmask = Net::IP::ip_get_mask($netmask, 6);
 
-    my $type = Net::IP::ip_iptypev6($binip);
+    my $type = ($binip eq $binmask) ? 'ANYCAST' : Net::IP::ip_iptypev6($binip);
 
-    raise_param_exc({ address => "$address is not a valid host ip address." })
-       if ($binip eq $binmask) ||
-          (defined($type) && $type !~ /^(?:(?:GLOBAL|(?:UNIQUE|LINK)-LOCAL)-UNICAST)$/);
+    if (defined($type) && $type !~ /^(?:(?:GLOBAL|(?:UNIQUE|LINK)-LOCAL)-UNICAST)$/) {
+       raise_param_exc({ address => "$address with type '$type', cannot be used as host IPv6 address." })
+    }
 };
 
 my $map_cidr_to_address_netmask = sub {