]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: panel/IPSet: eslint fixes
authorDominic Jäger <d.jaeger@proxmox.com>
Wed, 19 May 2021 10:56:19 +0000 (12:56 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 19 May 2021 12:03:08 +0000 (14:03 +0200)
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
www/manager6/panel/IPSet.js

index 303e518a565c63bc5e0e1d15c5ef7d665f5a8a90..94117789d043bbef7a7ed11de999eba90cf6eedd 100644 (file)
@@ -22,11 +22,11 @@ Ext.define('PVE.IPSetList', {
     initComponent: function() {
         var me = this;
 
-       if (me.ipset_panel == undefined) {
+       if (typeof me.ipset_panel === 'undefined') {
            throw "no rule panel specified";
        }
 
-       if (me.base_url == undefined) {
+       if (typeof me.ipset_panel === 'undefined') {
            throw "no base_url specified";
        }
 
@@ -143,7 +143,7 @@ Ext.define('PVE.IPSetList', {
            ],
            listeners: {
                itemdblclick: run_editor,
-               select: function(sm, rec) {
+               select: function(_, rec) {
                    var url = me.base_url + '/' + rec.data.name;
                    me.ipset_panel.setBaseUrl(url);
                },
@@ -346,7 +346,7 @@ Ext.define('PVE.IPSetGrid', {
                    metaData.tdCls = 'proxmox-invalid-row';
                    var html = '<p>' + Ext.htmlEncode(msg) + '</p>';
                    metaData.tdAttr = 'data-qwidth=600 data-qtitle="ERROR" data-qtip="' +
-                       html.replace(/\"/g, '&quot;') + '"';
+                       html.replace(/"/g, '&quot;') + '"';
                }
            }
            return value;