]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: eslint: enforce "dot-notation" rule
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 19 Jan 2021 16:45:01 +0000 (17:45 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 19 Jan 2021 16:45:01 +0000 (17:45 +0100)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
23 files changed:
www/manager6/Parser.js
www/manager6/Utils.js
www/manager6/ceph/CephInstallWizard.js
www/manager6/form/CPUModelSelector.js
www/manager6/form/SpiceEnhancementSelector.js
www/manager6/form/USBSelector.js
www/manager6/form/VLanField.js
www/manager6/lxc/CreateWizard.js
www/manager6/lxc/DNS.js
www/manager6/lxc/Options.js
www/manager6/lxc/Resources.js
www/manager6/qemu/CloudInit.js
www/manager6/qemu/CreateWizard.js
www/manager6/qemu/HDMove.js
www/manager6/qemu/HardwareView.js
www/manager6/qemu/IPConfigEdit.js
www/manager6/qemu/MemoryEdit.js
www/manager6/qemu/Options.js
www/manager6/qemu/ProcessorEdit.js
www/manager6/qemu/SSHKey.js
www/manager6/storage/NFSEdit.js
www/manager6/storage/TemplateView.js
www/manager6/window/Migrate.js

index a7d7fe01c98bef2721ba7f7630f5324940132dd0..163cbbac23bd0ff10446cd3f1fb72c0c15c1956a 100644 (file)
@@ -195,7 +195,7 @@ Ext.define('PVE.Parser', {
        if (!match_res) {
            return;
        }
-       res['interface'] = match_res[1];
+       res.interface = match_res[1];
        res.index = match_res[2];
 
        var errors = false;
index 074823036aca70bd47707f2354169610615ea5f6..5278152da5a47dcd0434b7f8bf9f95c6d1d2d801 100644 (file)
@@ -1360,14 +1360,14 @@ Ext.define('PVE.Utils', {
     delete_if_default: function(values, fieldname, default_val, create) {
        if (values[fieldname] === '' || values[fieldname] === default_val) {
            if (!create) {
-               if (values['delete']) {
-                   if (Ext.isArray(values['delete'])) {
-                       values['delete'].push(fieldname);
+               if (values.delete) {
+                   if (Ext.isArray(values.delete)) {
+                       values.delete.push(fieldname);
                    } else {
-                       values['delete'] += ',' + fieldname;
+                       values.delete += ',' + fieldname;
                    }
                } else {
-                   values['delete'] = fieldname;
+                   values.delete = fieldname;
                }
            }
 
index a763005659a7435caf73aea4cd30e5999fcf4141..74e3d1c2e2246795c2a681b81ba427249b256d2a 100644 (file)
@@ -457,7 +457,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
                if (!this.up('pveCephInstallWizard').getViewModel().get('configuration')) {
                    var wizard = me.up('window');
                    var kv = wizard.getValues();
-                   delete kv['delete'];
+                   delete kv.delete;
                    var monNode = kv['mon-node'];
                    delete kv['mon-node'];
                    var nodename = me.nodename;
index 78ec422c3b93e3ba8dbb63630c7258f9ecdb67fa..225cdaa129834ea8b1f0cb51bfffbb257e05064c 100644 (file)
@@ -59,8 +59,8 @@ Ext.define('PVE.form.CPUModelSelector', {
                    let b = recordB.data;
 
                    let vendorOrder = PVE.Utils.cpu_vendor_order;
-                   let orderA = vendorOrder[a.vendor] || vendorOrder['_default_'];
-                   let orderB = vendorOrder[b.vendor] || vendorOrder['_default_'];
+                   let orderA = vendorOrder[a.vendor] || vendorOrder._default_;
+                   let orderB = vendorOrder[b.vendor] || vendorOrder._default_;
 
                    if (orderA > orderB) {
                        return 1;
index 418542088aa15909d963f24eaed67f635e4d9d9d..525479e260c4b7db46c23f5fc1d5a9e931b37355 100644 (file)
@@ -66,7 +66,7 @@ Ext.define('PVE.form.SpiceEnhancementSelector', {
        }
        if (values.spice_enhancements) {
            var enhancements = PVE.Parser.parsePropertyString(values.spice_enhancements);
-           enhancements['foldersharing'] = PVE.Parser.parseBoolean(enhancements['foldersharing'], 0);
+           enhancements.foldersharing = PVE.Parser.parseBoolean(enhancements.foldersharing, 0);
            this.callParent([enhancements]);
        }
     },
index 355bc88ccd002e6e16eea000347bd6ce47cce9e2..d0d5c4c2d57bded7923536552172f1fc3c89be78 100644 (file)
@@ -44,7 +44,7 @@ Ext.define('PVE.form.USBSelector', {
            },
            filters: [
                function(item) {
-                   return !!item.data.usbpath && !!item.data.prodid && item.data['class'] != 9;
+                   return !!item.data.usbpath && !!item.data.prodid && item.data.class != 9;
                },
            ],
        });
index 07105dc515d9a21f12a9e4e35e08ece22e09f8c2..7379789ab5f97fddbca061b8345e2a0fa4373557 100644 (file)
@@ -21,7 +21,7 @@ Ext.define('PVE.form.VlanField', {
                 data[me.getName()] = val;
             } else if (me.deleteEmpty) {
                data = {};
-                data['delete'] = me.getName();
+                data.delete = me.getName();
            }
         }
         return data;
index 387e7da8f86a8951f16c4f8074c478346c9d9f4c..7be300ad5a476fc9eec398c1fd20ef6ed4848f9b 100644 (file)
@@ -285,7 +285,7 @@ Ext.define('PVE.lxc.CreateWizard', {
            onSubmit: function() {
                var wizard = this.up('window');
                var kv = wizard.getValues();
-               delete kv['delete'];
+               delete kv.delete;
 
                var nodename = kv.nodename;
                delete kv.nodename;
index d68d1845badc8f7becbe28fc4e6205ecf560c66c..9eb3d657a5928dcea1ef80bc02be0b7435080d90 100644 (file)
@@ -20,7 +20,7 @@ Ext.define('PVE.lxc.DNSInputPanel', {
        }
 
        if (deletes.length) {
-           values['delete'] = deletes.join(',');
+           values.delete = deletes.join(',');
        }
 
        return values;
@@ -227,7 +227,7 @@ Ext.define('PVE.lxc.DNS', {
            let rowdef = rows[key];
            edit_btn.setDisabled(!rowdef.editor);
 
-           let pending = rec.data['delete'] || me.hasPendingChanges(key);
+           let pending = rec.data.delete || me.hasPendingChanges(key);
            revert_btn.setDisabled(!pending);
        };
 
index 97d8137cdacfb0fc4e6a37a497896cff05fa0542..e1c4ce10c34f543fd6f1029d6aa7d66c62ff30cc 100644 (file)
@@ -172,7 +172,7 @@ Ext.define('PVE.lxc.Options', {
            }
 
            var key = rec.data.key;
-           var pending = rec.data['delete'] || me.hasPendingChanges(key);
+           var pending = rec.data.delete || me.hasPendingChanges(key);
            var rowdef = rows[key];
 
            edit_btn.setDisabled(!rowdef.editor);
index 2135d21f9c1516cca9c4084c96e642c6b95d0efd..02a9f9993aa93e8d0b80b6cb1a3336988b761b28 100644 (file)
@@ -230,11 +230,11 @@ Ext.define('PVE.lxc.RessourceView', {
            var value = rec.data.value;
            var rowdef = rows[key];
 
-           var pending = rec.data['delete'] || me.hasPendingChanges(key);
+           var pending = rec.data.delete || me.hasPendingChanges(key);
            var isDisk = rowdef.tdCls == 'pve-itype-icon-storage';
            var isUnusedDisk = key.match(/^unused\d+/);
 
-           var noedit = rec.data['delete'] || !rowdef.editor;
+           var noedit = rec.data.delete || !rowdef.editor;
            if (!noedit && Proxmox.UserName !== 'root@pam' && key.match(/^mp\d+$/)) {
                var mp = PVE.Parser.parseLxcMountPoint(value);
                if (mp.type !== 'volume') {
index 31a139b7397b7c197a16c958976d6cf2776e20f1..ccd1840bf3d4f2da526a5009b7db4fbc0a59cda4 100644 (file)
@@ -46,7 +46,7 @@ Ext.define('PVE.qemu.CloudInit', {
                }
 
                var params = {};
-               params['delete'] = id;
+               params.delete = id;
                Proxmox.Utils.API2Request({
                    url: me.baseurl + '/config',
                    waitMsgTarget: me,
index 666131e7c4d34814e7f01f4b2d8dfd54a9251eca..d4535c9d57b8cde6b63c16ebd511a4027a7d4337 100644 (file)
@@ -231,7 +231,7 @@ Ext.define('PVE.qemu.CreateWizard', {
            onSubmit: function() {
                var wizard = this.up('window');
                var kv = wizard.getValues();
-               delete kv['delete'];
+               delete kv.delete;
 
                var nodename = kv.nodename;
                delete kv.nodename;
index 6cb1552cd6367b129319ce048236156a52525b77..c9ef34d76770915a4da88b759c38e12b9f869e74 100644 (file)
@@ -16,7 +16,7 @@ Ext.define('PVE.window.HDMove', {
        }
 
        if (delete_disk) {
-           params['delete'] = 1;
+           params.delete = 1;
        }
 
        var url = '/nodes/' + me.nodename + '/' + me.type + '/' + me.vmid + '/';
index a2e20840e5060e784904b9467b1496a3ab0726e6..dc6f01676aa3bdbc50a45a16a9a311772cb98046 100644 (file)
@@ -584,7 +584,7 @@ Ext.define('PVE.qemu.HardwareView', {
            var value = rec.data.value;
            var rowdef = rows[key];
 
-           var pending = rec.data['delete'] || me.hasPendingChanges(key);
+           var pending = rec.data.delete || me.hasPendingChanges(key);
            var isCDRom = value && !!value.toString().match(/media=cdrom/);
            var isUnusedDisk = key.match(/^unused\d+/);
            var isUsedDisk = !isUnusedDisk && rowdef.isOnStorageBus && !isCDRom;
@@ -593,11 +593,11 @@ Ext.define('PVE.qemu.HardwareView', {
 
            var isEfi = key === 'efidisk0';
 
-           remove_btn.setDisabled(rec.data['delete'] || rowdef.never_delete === true || isUnusedDisk && !diskCap);
+           remove_btn.setDisabled(rec.data.delete || rowdef.never_delete === true || isUnusedDisk && !diskCap);
            remove_btn.setText(isUsedDisk && !isCloudInit ? remove_btn.altText : remove_btn.defaultText);
            remove_btn.RESTMethod = isUnusedDisk ? 'POST':'PUT';
 
-           edit_btn.setDisabled(rec.data['delete'] || !rowdef.editor || isCloudInit || !isCDRom && !diskCap);
+           edit_btn.setDisabled(rec.data.delete || !rowdef.editor || isCloudInit || !isCDRom && !diskCap);
 
            resize_btn.setDisabled(pending || !isUsedDisk || !diskCap);
 
index 53976333c719703113928fd2f6cf375c08608e42..6e6ec4f504ac99383a968a2888c3e82ced4c6d6a 100644 (file)
@@ -21,7 +21,7 @@ Ext.define('PVE.qemu.IPConfigPanel', {
 
        var cfg = PVE.Parser.printIPConfig(values);
        if (cfg === '') {
-           params['delete'] = [me.confid];
+           params.delete = [me.confid];
        } else {
            params[me.confid] = cfg;
        }
index 63c1294ff8d0ba4ecad3329163b375d8249bbbe1..0fdeca48e44982c5e6a29c72005ff38a356e61f4 100644 (file)
@@ -15,14 +15,14 @@ Ext.define('PVE.qemu.MemoryInputPanel', {
 
        if (!values.ballooning) {
            res.balloon = 0;
-           res['delete'] = 'shares';
+           res.delete = 'shares';
        } else if (values.memory === values.balloon) {
            delete res.balloon;
-           res['delete'] = 'balloon,shares';
+           res.delete = 'balloon,shares';
        } else if (Ext.isDefined(values.shares) && values.shares !== "") {
            res.shares = values.shares;
        } else {
-           res['delete'] = "shares";
+           res.delete = "shares";
        }
 
        return res;
index 25a68628661d468c14a1a4ab9ae298b7e56ebab7..a08da6e159f0e86b8b72c4df3aeca0e55ac2c6ab 100644 (file)
@@ -364,7 +364,7 @@ Ext.define('PVE.qemu.Options', {
            }
 
            var key = rec.data.key;
-           var pending = rec.data['delete'] || me.hasPendingChanges(key);
+           var pending = rec.data.delete || me.hasPendingChanges(key);
            var rowdef = rows[key];
 
            edit_btn.setDisabled(!rowdef.editor);
index 5dffbe7a0853c0d158c4d65dd25440c318e7ffb5..539e3e7d99a8189569eac72f236e042c4a8f2584 100644 (file)
@@ -23,8 +23,8 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
     onGetValues: function(values) {
        var me = this;
 
-       if (Array.isArray(values['delete'])) {
-           values['delete'] = values['delete'].join(',');
+       if (Array.isArray(values.delete)) {
+           values.delete = values.delete.join(',');
        }
 
        PVE.Utils.delete_if_default(values, 'cpulimit', '0', 0);
@@ -44,8 +44,8 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
        var cpustring = PVE.Parser.printQemuCpu(me.cpu);
 
        // remove cputype delete request:
-       var del = values['delete'];
-       delete values['delete'];
+       var del = values.delete;
+       delete values.delete;
        if (del) {
            del = del.split(',');
            Ext.Array.remove(del, 'cputype');
@@ -61,7 +61,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
 
        var delarr = del.join(',');
        if (delarr) {
-           values['delete'] = delarr;
+           values.delete = delarr;
        }
 
        return values;
index 89eefd4984afe67b08310991d25d84b8394bfe05..ec0307778850c13ccd51b35c650607871cfdfcf9 100644 (file)
@@ -11,7 +11,7 @@ Ext.define('PVE.qemu.SSHKeyInputPanel', {
        }
        if (!values.sshkeys.length) {
            values = {};
-           values['delete'] = 'sshkeys';
+           values.delete = 'sshkeys';
            return values;
        } else {
            values.sshkeys = encodeURIComponent(values.sshkeys);
index d582997edfcd04d42c3ddd4cf2864bd1318b64d6..5fc8265ce35cbf151187a91aee1ecdc54ca7ac90 100644 (file)
@@ -83,7 +83,7 @@ Ext.define('PVE.storage.NFSInputPanel', {
        if (values.options === '') {
            delete values.options;
            if (!me.isCreate) {
-               values["delete"] = "options";
+               values.delete = "options";
            }
        }
 
index 8230774d06aa041ea356b96b2372211152cdb021..6fcfd1d32da6bd58d21ee2ebe4e91079a4193caa 100644 (file)
@@ -53,7 +53,7 @@ Ext.define('PVE.grid.TemplateSelector', {
                            var value = field.getValue().toLowerCase();
                            store.clearFilter(true);
                            store.filterBy(function(rec) {
-                               return rec.data['package'].toLowerCase().indexOf(value) !== -1 ||
+                               return rec.data.package.toLowerCase().indexOf(value) !== -1 ||
                                rec.data.headline.toLowerCase().indexOf(value) !== -1;
                            });
                        },
index 9c03e23115130f811182e3b5792731f113314607..817d99ed3ec2c2b8f64d3fc68fd6b8a9bb73e255 100644 (file)
@@ -132,7 +132,7 @@ Ext.define('PVE.window.Migrate', {
            }
 
            if (vm.get('migration.overwriteLocalResourceCheck')) {
-               params['force'] = 1;
+               params.force = 1;
            }
 
            Proxmox.Utils.API2Request({