ui: dc: backup: fix job detail search

'for...in array' returns the id in the array but not the value,
'for...of array' returns the values.

Another issue that I ran into was if the property did not exist.

Checking if the property evaluates to false will catch situations where
the property does not exist or is null. All other situations where there
is a value for the name, id or type, should evaluate to true if present
as they are strings or the VMID.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 9940115459abf8620bb2730198efe818941a2ede..6be545eedfc487f987c180c3f423cf999dae019c 100644 (file)
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -515,8 +515,8 @@ Ext.define('PVE.dc.BackupDiskTree', {
                                    data = record.parentNode.data;
                                }
 
-                               for (const property in ['name', 'id', 'type']) {
-                                   if (data[property] === null) {
+                               for (const property of ['name', 'id', 'type']) {
+                                   if (!data[property]) {
                                        continue;
                                    }
                                    let v = data[property].toString();