]> git.proxmox.com Git - pve-manager.git/commitdiff
ui: vm selector: gracefully handle empty IDs in setValue function
authorFiona Ebner <f.ebner@proxmox.com>
Mon, 25 Sep 2023 11:58:39 +0000 (13:58 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 27 Sep 2023 14:53:14 +0000 (16:53 +0200)
An empty string is passed by the backup job window when using
selection mode 'all', would be converted to [""] and wrongly add an
entry with VMID 0 because the item "" could not be found in the store.

Reported in the community forum:
https://forum.proxmox.com/threads/130164/

Fixes: 7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup edit")
Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
www/manager6/form/VMSelector.js

index 4c0bba137d6e41d52414d4138dcf65cfaea1ff3d..0c884aaead5530dd5663569603f9bde213611b80 100644 (file)
@@ -162,7 +162,7 @@ Ext.define('PVE.form.VMSelector', {
     setValue: function(value) {
        let me = this;
        if (!Ext.isArray(value)) {
-           value = value.split(',');
+           value = value.split(',').filter(v => v !== '');
        }
 
        let store = me.getStore();