]> git.proxmox.com Git - pve-manager.git/commitdiff
move cmdmenu function and use it in poolmemberlist
authorDominik Csapak <d.csapak@proxmox.com>
Thu, 19 May 2016 12:27:05 +0000 (14:27 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Fri, 20 May 2016 05:30:21 +0000 (07:30 +0200)
we had the function for the cmdmenu at two
different places (resourcetree and resourcegrid)

move it to PVE.Utils to reuse code, and
also use it in pool members list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
www/manager6/Utils.js
www/manager6/grid/PoolMembers.js
www/manager6/grid/ResourceGrid.js
www/manager6/tree/ResourceTree.js

index 7fd0298e161cca5c9e4eed771296610d441ebf24..992ae85e4becc03cf97f59afc88770244a65bb7f 100644 (file)
@@ -1184,7 +1184,37 @@ Ext.define('PVE.Utils', { statics: {
            }
            PVE.Utils.setErrorMask(me, msg);
        });
-    }
+    },
 
+    createCmdMenu: function(v, record, item, index, event) {
+       event.stopEvent();
+       v.select(record);
+       var menu;
+
+       if (record.data.type === 'qemu' && !record.data.template) {
+           menu = Ext.create('PVE.qemu.CmdMenu', {
+               pveSelNode: record
+           });
+       } else if (record.data.type === 'qemu' && record.data.template) {
+           menu = Ext.create('PVE.qemu.TemplateMenu', {
+               pveSelNode: record
+           });
+       } else if (record.data.type === 'lxc' && !record.data.template) {
+           menu = Ext.create('PVE.lxc.CmdMenu', {
+               pveSelNode: record
+           });
+       } else if (record.data.type === 'lxc' && record.data.template) {
+           /* since clone does not work reliably, disable for now
+           menu = Ext.create('PVE.lxc.TemplateMenu', {
+               pveSelNode: record
+           });
+           */
+           return;
+       } else {
+           return;
+       }
+
+       menu.showAt(event.getXY());
+    }
 }});
 
index aec15bed5844f01bac019a1a048703a75c2cbbfd..6c7164d98e2627c9130e730e0314f76afda4bf2e 100644 (file)
@@ -237,6 +237,7 @@ Ext.define('PVE.grid.PoolMembers', {
             },
             columns: coldef,
            listeners: {
+               itemcontextmenu: PVE.Utils.createCmdMenu,
                activate: reload
            }
        });
index 935bdd0a5ec15d1e2bf3e83665af42514578ad8b..ad6f05dd62c8132f77c64dc7f4f6cc73624e231f 100644 (file)
@@ -186,36 +186,7 @@ Ext.define('PVE.grid.ResourceGrid', {
                stripeRows: true
             },
            listeners: {
-               itemcontextmenu: function(v, record, item, index, event) {
-                   event.stopEvent();
-                   v.select(record);
-                   var menu;
-                   
-                   if (record.data.type === 'qemu' && !record.data.template) {
-                       menu = Ext.create('PVE.qemu.CmdMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'qemu' && record.data.template) {
-                       menu = Ext.create('PVE.qemu.TemplateMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'lxc' && !record.data.template) {
-                       menu = Ext.create('PVE.lxc.CmdMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'lxc' && record.data.template) {
-                       /* since clone does not work reliably, disable for now
-                       menu = Ext.create('PVE.lxc.TemplateMenu', {
-                           pveSelNode: record
-                       });
-                       */
-                       return;
-                   } else {
-                       return;
-                   }
-
-                   menu.showAt(event.getXY());
-               },
+               itemcontextmenu: PVE.Utils.createCmdMenu,
                itemdblclick: function(v, record) {
                    var ws = me.up('pveStdWorkspace');
                    ws.selectById(record.data.id);
index d94a63ce108fe5363640cb3c4d9a00d31172a197..b15ed4f15c91b1a56cfe604fc70cd34c21409e2e 100644 (file)
@@ -375,36 +375,7 @@ Ext.define('PVE.tree.ResourceTree', {
             //rootVisible: false,
             //title: 'Resource Tree',
            listeners: {
-               itemcontextmenu: function(v, record, item, index, event) {
-                   event.stopEvent();
-                   //v.select(record);
-                   var menu;
-                   
-                   if (record.data.type === 'qemu' && !record.data.template) {
-                       menu = Ext.create('PVE.qemu.CmdMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'qemu' && record.data.template) {
-                       menu = Ext.create('PVE.qemu.TemplateMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'lxc' && !record.data.template) {
-                       menu = Ext.create('PVE.lxc.CmdMenu', {
-                           pveSelNode: record
-                       });
-                   } else if (record.data.type === 'lxc' && record.data.template) {
-                       /* since clone does not work reliably, disable for now
-                       menu = Ext.create('PVE.lxc.TemplateMenu', {
-                           pveSelNode: record
-                       });
-                       */
-                       return;
-                   } else {
-                       return;
-                   }
-
-                   menu.showAt(event.getXY());
-               },
+               itemcontextmenu: PVE.Utils.createCmdMenu,
                destroy: function() {
                    rstore.un("load", updateTree);
                },